From c5d6af43fb544423fa103f523ac85356b3ff3725 Mon Sep 17 00:00:00 2001 From: Keith Hui Date: Mon, 20 Mar 2023 02:03:47 -0400 Subject: nb/intel/snb: Abolish mainboard_should_reset_usb() Of the 13 mainboards that implement mainboard_should_reset_usb() hook, all but one do the same: Stop MRC from resetting USB when resuming from S3 suspend. This hook turns out is only here to facilitate a USB reset workaround on samsung/stumpy for an old ChromeOS kernel which is no longer needed. Drop the workaround, the hook, and headers no longer used. roda/rv11/early_init.c is left with no useful code after this patch, so drop it entirely from both bootblock and romstage. Change-Id: Ib3a5a00c0a6b1528e39435784919223d16b3914e Signed-off-by: Keith Hui Reviewed-on: https://review.coreboot.org/c/coreboot/+/72496 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/mainboard/roda/rv11/Makefile.inc | 2 -- src/mainboard/roda/rv11/early_init.c | 9 --------- 2 files changed, 11 deletions(-) delete mode 100644 src/mainboard/roda/rv11/early_init.c (limited to 'src/mainboard/roda/rv11') diff --git a/src/mainboard/roda/rv11/Makefile.inc b/src/mainboard/roda/rv11/Makefile.inc index cb9c72573f..58414012fb 100644 --- a/src/mainboard/roda/rv11/Makefile.inc +++ b/src/mainboard/roda/rv11/Makefile.inc @@ -8,5 +8,3 @@ romstage-y += variants/$(VARIANT_DIR)/early_init.c ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += variants/$(VARIANT_DIR)/gma-mainboard.ads CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include -bootblock-y += early_init.c -romstage-y += early_init.c diff --git a/src/mainboard/roda/rv11/early_init.c b/src/mainboard/roda/rv11/early_init.c deleted file mode 100644 index 34770be791..0000000000 --- a/src/mainboard/roda/rv11/early_init.c +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -int mainboard_should_reset_usb(int s3resume) -{ - return !s3resume; -} -- cgit v1.2.3