From 521e0460e4292ff0bdaad4ca3861603d13ccfe1d Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Fri, 2 Dec 2022 19:16:21 +0200 Subject: sb,soc/intel,mb: Drop leftover comments and TODOs in ASL MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I74f943e9b616458a16aa13c29706cf1551fcbbb2 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/70366 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Arthur Heymans --- src/mainboard/ocp/deltalake/acpi/platform.asl | 18 ------------------ src/mainboard/ocp/tiogapass/acpi/platform.asl | 18 ------------------ 2 files changed, 36 deletions(-) (limited to 'src/mainboard/ocp') diff --git a/src/mainboard/ocp/deltalake/acpi/platform.asl b/src/mainboard/ocp/deltalake/acpi/platform.asl index 5a15b29920..2b0775d37a 100644 --- a/src/mainboard/ocp/deltalake/acpi/platform.asl +++ b/src/mainboard/ocp/deltalake/acpi/platform.asl @@ -23,16 +23,6 @@ Field (APMP, ByteAcc, NoLock, Preserve) #include -/* IO-Trap at 0x800. - * This is the ACPI->SMI communication interface. - */ -OperationRegion (IO_T, SystemIO, 0x800, 0x10) -Field (IO_T, ByteAcc, NoLock, Preserve) -{ - Offset (0x8), - TRP0, 8 /* IO-Trap at 0x808 */ -} - OperationRegion (PSYS, SystemMemory, 0x6D081000, 0x0400) Field (PSYS, ByteAcc, NoLock, Preserve) { @@ -320,14 +310,6 @@ Field (PSYS, ByteAcc, NoLock, Preserve) FKB7, 8 } -/* SMI I/O Trap */ -Method (TRAP, 1, Serialized) -{ - SMIF = Arg0 // SMI Function - TRP0 = 0 // Generate trap - Return (SMIF) // Return value of SMI handler -} - /* * The _PTS method (Prepare To Sleep) is called before the OS is * entering a sleep state. The sleep state number is passed in Arg0 diff --git a/src/mainboard/ocp/tiogapass/acpi/platform.asl b/src/mainboard/ocp/tiogapass/acpi/platform.asl index 782d2cd26f..1899de1a18 100644 --- a/src/mainboard/ocp/tiogapass/acpi/platform.asl +++ b/src/mainboard/ocp/tiogapass/acpi/platform.asl @@ -23,16 +23,6 @@ Field (APMP, ByteAcc, NoLock, Preserve) #include -/* IO-Trap at 0x800. - * This is the ACPI->SMI communication interface. - */ -OperationRegion (IO_T, SystemIO, 0x800, 0x10) -Field (IO_T, ByteAcc, NoLock, Preserve) -{ - Offset (0x8), - TRP0, 8 /* IO-Trap at 0x808 */ -} - OperationRegion (PSYS, SystemMemory, 0x6D081000, 0x0400) Field (PSYS, ByteAcc, NoLock, Preserve) { @@ -320,14 +310,6 @@ Field (PSYS, ByteAcc, NoLock, Preserve) FKB7, 8 } -/* SMI I/O Trap */ -Method (TRAP, 1, Serialized) -{ - SMIF = Arg0 // SMI Function - TRP0 = 0 // Generate trap - Return (SMIF) // Return value of SMI handler -} - /* * The _PTS method (Prepare To Sleep) is called before the OS is * entering a sleep state. The sleep state number is passed in Arg0 -- cgit v1.2.3