From d73c1b5bf1246855a4d4e847702214a3eeb6ab82 Mon Sep 17 00:00:00 2001 From: Myles Watson Date: Mon, 26 Oct 2009 15:14:07 +0000 Subject: Define some variables that were not defined. There are a couple left. Do kbuildall then grep not.defined kbuildall.results/* The interesting ones were GENERATE_* I had to put them in twice to make it work correctly: once outside the menu setting the defaults, and once inside the menu. Now they show up when they should, and are always defined Define HAVE_INIT_TIMER to only exclude the three boards that define it to be 0 in newconfig. Define MEM_TRAIN_SEQ to be an integer and set it correctly. Remove CAR_FAM10 and just depend on NORTHBRIDGE_AMD_AMDFAM10 MOVNTI is a performance enhancement, and should default to 0 so it doesn't break boards that forget to define it. Signed-off-by: Myles Watson Acked-by: Uwe Hermann git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4856 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- src/mainboard/msi/ms7135/Kconfig | 15 +++++---------- src/mainboard/msi/ms7260/Kconfig | 6 +++++- src/mainboard/msi/ms9282/Kconfig | 1 - 3 files changed, 10 insertions(+), 12 deletions(-) (limited to 'src/mainboard/msi') diff --git a/src/mainboard/msi/ms7135/Kconfig b/src/mainboard/msi/ms7135/Kconfig index 674fd90286..f9410fd784 100644 --- a/src/mainboard/msi/ms7135/Kconfig +++ b/src/mainboard/msi/ms7135/Kconfig @@ -22,6 +22,11 @@ config APIC_ID_OFFSET default 0x10 depends on BOARD_MSI_MS7135 +config MEM_TRAIN_SEQ + int + default 1 + depends on BOARD_MSI_MS7135 + config SB_HT_CHAIN_ON_BUS0 int default 2 @@ -52,11 +57,6 @@ config HW_MEM_HOLE_SIZEK default 0x100000 depends on BOARD_MSI_MS7135 -config MEM_TRAIN_SEQ - bool - default n - depends on BOARD_MSI_MS7135 - config MAX_CPUS int default 2 @@ -67,11 +67,6 @@ config MAX_PHYSICAL_CPUS default 1 depends on BOARD_MSI_MS7135 -config MEM_TRAIN_SEQ - bool - default n - depends on BOARD_MSI_MS7135 - config HW_MEM_HOLE_SIZE_AUTO_INC bool default n diff --git a/src/mainboard/msi/ms7260/Kconfig b/src/mainboard/msi/ms7260/Kconfig index 3e9568b0b3..997733bbf6 100644 --- a/src/mainboard/msi/ms7260/Kconfig +++ b/src/mainboard/msi/ms7260/Kconfig @@ -13,7 +13,6 @@ config BOARD_MSI_MS7260 select HAVE_HARD_RESET select IOAPIC select LIFT_BSP_APIC_ID - select MEM_TRAIN_SEQ select SB_HT_CHAIN_UNITID_OFFSET_ONLY select K8_REV_F_SUPPORT select BOARD_ROMSIZE_KB_512 @@ -43,6 +42,11 @@ config APIC_ID_OFFSET default 16 depends on BOARD_MSI_MS7260 +config MEM_TRAIN_SEQ + int + default 1 + depends on BOARD_MSI_MS7260 + config SB_HT_CHAIN_ON_BUS0 int default 2 diff --git a/src/mainboard/msi/ms9282/Kconfig b/src/mainboard/msi/ms9282/Kconfig index 35d00a35d1..4911c576b9 100644 --- a/src/mainboard/msi/ms9282/Kconfig +++ b/src/mainboard/msi/ms9282/Kconfig @@ -12,7 +12,6 @@ config BOARD_MSI_MS9282 select USE_DCACHE_RAM select HAVE_HARD_RESET select IOAPIC - select MEM_TRAIN_SEQ select SB_HT_CHAIN_UNITID_OFFSET_ONLY select K8_REV_F_SUPPORT select BOARD_ROMSIZE_KB_512 -- cgit v1.2.3