From 3627f2903c8597b8765117146cf2868daecfe305 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Mon, 15 Nov 2021 20:11:45 +0100 Subject: cpu/intel/model_2065x: Don't use a magic APIC MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Move the chip configuration to the cpu cluster device. It looks like none of the devicetree were featuring a lapic 0xacac, nor was tcc_offset ever set, so this remains a NOP. Change-Id: I296631511b0e31b0ed43ca8193552483bdab4482 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/59315 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki --- src/mainboard/lenovo/t410/devicetree.cb | 7 ++----- src/mainboard/lenovo/x201/devicetree.cb | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) (limited to 'src/mainboard/lenovo') diff --git a/src/mainboard/lenovo/t410/devicetree.cb b/src/mainboard/lenovo/t410/devicetree.cb index 4631b8e0e0..200cabbb92 100644 --- a/src/mainboard/lenovo/t410/devicetree.cb +++ b/src/mainboard/lenovo/t410/devicetree.cb @@ -17,11 +17,8 @@ chip northbridge/intel/ironlake register "gpu_cpu_backlight" = "0x58d" register "gpu_pch_backlight" = "0x061a061a" - device cpu_cluster 0 on - ops ironlake_cpu_bus_ops - chip cpu/intel/model_2065x - device lapic 0 on end - end + chip cpu/intel/model_2065x + device cpu_cluster 0 on ops ironlake_cpu_bus_ops end end device domain 0 on diff --git a/src/mainboard/lenovo/x201/devicetree.cb b/src/mainboard/lenovo/x201/devicetree.cb index 73b043720b..fc7c470091 100644 --- a/src/mainboard/lenovo/x201/devicetree.cb +++ b/src/mainboard/lenovo/x201/devicetree.cb @@ -18,11 +18,8 @@ chip northbridge/intel/ironlake register "gpu_cpu_backlight" = "0x58d" register "gpu_pch_backlight" = "0x061a061a" - device cpu_cluster 0 on - ops ironlake_cpu_bus_ops - chip cpu/intel/model_2065x - device lapic 0 on end - end + chip cpu/intel/model_2065x + device cpu_cluster 0 on ops ironlake_cpu_bus_ops end end device domain 0 on -- cgit v1.2.3