From 05ae8f2ff31ba1d02aba15c99025df91588712e1 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Mon, 8 Mar 2021 10:35:49 +0100 Subject: mainboard: Drop invalid `VGA_BIOS_FILE` defaults MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If the VGA BIOS file path for `VGA_BIOS_FILE` in a mainboard's Kconfig does not exist in the coreboot tree (including submodules), drop it. These files should be stored in the `site-local` subdirectory and the paths specified for each board in `site-local/Kconfig`. For example: config VGA_BIOS_FILE default "site-local/x200_vbios.bin" if BOARD_LENOVO_X200 Note that this is just an example. There are better ways to structure one's `site-local` subfolder. Using the `CONFIG_MAINBOARD_DIR` option would be one of them, though variants may still need special handling. Also, update autoport to not generate `VGA_BIOS_FILE` defaults. Change-Id: I1b5dfba035a42d7943f270f95fb7d32b285584d2 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/51340 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Michael Niewöhner Reviewed-by: Felix Singer --- src/mainboard/lenovo/x220/Kconfig | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'src/mainboard/lenovo/x220') diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig index 8530e49dc5..61b3c1489e 100644 --- a/src/mainboard/lenovo/x220/Kconfig +++ b/src/mainboard/lenovo/x220/Kconfig @@ -67,15 +67,10 @@ config DRAM_RESET_GATE_GPIO int default 10 -config VGA_BIOS_FILE - string - default "pci8086,0116.rom" if BOARD_LENOVO_X220I - # FIXME: x1 with i3 cpu may also use "pci8086,0116.rom" - default "pci8086,0126.rom" - config VGA_BIOS_ID string default "8086,0116" if BOARD_LENOVO_X220I + # FIXME: x1 with i3 cpu may also use "8086,0116" default "8086,0126" config PS2K_EISAID -- cgit v1.2.3