From cd26f08d942638da9a6aa85bb8bd873197f467c8 Mon Sep 17 00:00:00 2001 From: Praveen hodagatta pranesh Date: Wed, 19 Dec 2018 19:28:21 +0800 Subject: mb/intel/kblrvp: Add helper function to get Board Id Add 2 helper function get_board_id() & get_spd_index() to read board id & spd index from EC. Rename the old get_board_id() function to get_ec_boardinfo(). BUG=None TEST= Tested on KBL RVP11, able to read the Board id (0x44) and verified in serial logs. not verified on KBL RVP8. Signed-off-by: Praveen hodagatta pranesh Change-Id: Ie20bf0d45a3568c2c433e5b844bea86aac07c47d Reviewed-on: https://review.coreboot.org/c/30306 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- src/mainboard/intel/kblrvp/romstage.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/mainboard/intel/kblrvp/romstage.c') diff --git a/src/mainboard/intel/kblrvp/romstage.c b/src/mainboard/intel/kblrvp/romstage.c index a29a4afc44..47f8249739 100644 --- a/src/mainboard/intel/kblrvp/romstage.c +++ b/src/mainboard/intel/kblrvp/romstage.c @@ -31,7 +31,9 @@ void mainboard_memory_init_params(FSPM_UPD *mupd) { FSP_M_CONFIG *mem_cfg; mem_cfg = &mupd->FspmConfig; - u8 spd_index = (get_board_id() >> 5) & 0x7; + u8 spd_index = get_spd_index(); + if ((int)spd_index < 0) + return; printk(BIOS_INFO, "SPD index %d\n", spd_index); -- cgit v1.2.3