From c5d6af43fb544423fa103f523ac85356b3ff3725 Mon Sep 17 00:00:00 2001 From: Keith Hui Date: Mon, 20 Mar 2023 02:03:47 -0400 Subject: nb/intel/snb: Abolish mainboard_should_reset_usb() Of the 13 mainboards that implement mainboard_should_reset_usb() hook, all but one do the same: Stop MRC from resetting USB when resuming from S3 suspend. This hook turns out is only here to facilitate a USB reset workaround on samsung/stumpy for an old ChromeOS kernel which is no longer needed. Drop the workaround, the hook, and headers no longer used. roda/rv11/early_init.c is left with no useful code after this patch, so drop it entirely from both bootblock and romstage. Change-Id: Ib3a5a00c0a6b1528e39435784919223d16b3914e Signed-off-by: Keith Hui Reviewed-on: https://review.coreboot.org/c/coreboot/+/72496 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/mainboard/intel/dcp847ske/romstage.c | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/mainboard/intel/dcp847ske') diff --git a/src/mainboard/intel/dcp847ske/romstage.c b/src/mainboard/intel/dcp847ske/romstage.c index 0232486403..e7b936ae35 100644 --- a/src/mainboard/intel/dcp847ske/romstage.c +++ b/src/mainboard/intel/dcp847ske/romstage.c @@ -41,9 +41,4 @@ void mainboard_fill_pei_data(struct pei_data *pei_data) }; *pei_data = pei_data_template; } - -int mainboard_should_reset_usb(int s3resume) -{ - return !s3resume; -} #endif -- cgit v1.2.3