From deb2cb27e9bade18c4d186899edfaeabfc1131bd Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Fri, 28 Mar 2014 23:46:45 +0200 Subject: Static CBMEM / CAR: Flag boards with BROKEN_CAR_MIGRATE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use of CAR_GLOBAL is not safe after CAR is torn down, unless the board properly implements EARLY_CBMEM_INIT. Flag vulnerable boards that only do cbmem_recovery() in romstage on S3 resume and implementation with Intel FSP that invalidates cache before we have a chance to copy the contents. Change-Id: Iecd10dee9b73ab3f1f66826950fa0945675ff39f Signed-off-by: Kyösti Mälkki Reviewed-on: http://review.coreboot.org/5419 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/mainboard/intel/cougar_canyon2/Kconfig | 1 + 1 file changed, 1 insertion(+) (limited to 'src/mainboard/intel/cougar_canyon2') diff --git a/src/mainboard/intel/cougar_canyon2/Kconfig b/src/mainboard/intel/cougar_canyon2/Kconfig index 569888d3c9..61f1c6d34b 100644 --- a/src/mainboard/intel/cougar_canyon2/Kconfig +++ b/src/mainboard/intel/cougar_canyon2/Kconfig @@ -14,6 +14,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select SUPERIO_SMSC_SIO1007 select ENABLE_VMX select EARLY_CBMEM_INIT + select BROKEN_CAR_MIGRATE config MAINBOARD_DIR string -- cgit v1.2.3