From 49fe84e2c2f83fb2b31900c6bcafb2631aeb46de Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Wed, 13 Mar 2024 16:43:09 +0100 Subject: soc/intel/xeon_sp/spr: Enable 512 MMCONF buses by default As of now coreboot only supported one PCI segment group and thus the MMCONF size had to be limited to 256 buses on ibm/sbp1. Since the default FSP doesn't allow to disable unused IIO stacks a patched version had to be used. Those unused IIO stacks consume lots of PCI bus ranges, leaving no free buses for the secondary side behind PCI bridges. The IIO disable mechanism doesn't work after ACPI G3 exit and thus requires multiple reboots when the previous state was G3. Since coreboot now supports multi PCI segment groups enable 512 MMCONF buses on 4S platforms by default and drop the IIO stack disable UPDs on ibm/sbp1. This allows to boot faster without the need for a patched FSP. The use of multiple PCI segment groups might prevent legacy software from working properly, however the only board where multiple PCI segment groups are used uses u-root as default payload. TEST=Booted on ibm/sbp1 to ubuntu22.04 using two PCI segment groups. TEST=intel/archercity CRB Change-Id: I4e6e5eca1196d4ab50e43b4b58d24eca444ab519 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/81187 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/mainboard/ibm/sbp1/romstage.c | 20 -------------------- 1 file changed, 20 deletions(-) (limited to 'src/mainboard/ibm/sbp1') diff --git a/src/mainboard/ibm/sbp1/romstage.c b/src/mainboard/ibm/sbp1/romstage.c index 5cda689162..365d6b10ae 100644 --- a/src/mainboard/ibm/sbp1/romstage.c +++ b/src/mainboard/ibm/sbp1/romstage.c @@ -270,8 +270,6 @@ static const UINT8 sbp1_socket_config_iou[CONFIG_MAX_SOCKET][5] = { void mainboard_memory_init_params(FSPM_UPD *mupd) { - UINT32 *sktbmp; - /* Set Rank Margin Tool to disable. */ mupd->FspmConfig.EnableRMT = 0x0; @@ -287,25 +285,7 @@ void mainboard_memory_init_params(FSPM_UPD *mupd) else mupd->FspmConfig.serialDebugMsgLvl = 0; - /* Force 256MiB MMCONF (Segment0) only */ - mupd->FspmConfig.mmCfgSize = 0x2; mupd->FspmConfig.PcieHotPlugEnable = 1; - - /* - * Disable unused IIO stack: - * Socket 0 : IIO1, IIO4 - * Socket 1 : IIO1, IIO2 - * Socket 2 : IIO1, IIO5 - * Socket 3 : IIO1, IIO5 - * Stack Disable bit mapping is: - * IIO stack number: 1 2 3 4 5 - * Stack Disable Bit: 1 5 3 2 4 - */ - sktbmp = (UINT32 *)&mupd->FspmConfig.StackDisableBitMap[0]; - sktbmp[0] = BIT(1) | BIT(2); - sktbmp[1] = BIT(1) | BIT(5); - sktbmp[2] = BIT(1) | BIT(4); - sktbmp[3] = BIT(1) | BIT(4); soc_config_iio(mupd, sbp1_socket_config, sbp1_socket_config_iou); } -- cgit v1.2.3