From 88f94a9635cd64aaf6eeb3ed3991dceabcf6387a Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Fri, 19 Mar 2021 15:13:46 +0100 Subject: lynxpoint/broadwell: Rename LP GPIO config global Do not use the same name as the non-LP GPIO config. This allows checking at build-time that a mainboard uses the correct GPIO config format. Without this commit, there are no build-time errors when using the wrong format of GPIO config, but there would be undefined behavior at runtime. Tested by trying to build asrock/b85m_pro4 and hp/folio_9480m after toggling the `INTEL_LYNXPOINT_LP` Kconfig option (and trimming down the USB config arrays for asrock/b85m_pro4). In both cases, building failed because the necessary GPIO config global is not defined, as expected. Change-Id: Ib06507ef8179da22bdb27593daf972e788051f3a Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/51661 Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) --- src/mainboard/hp/folio_9480m/gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/mainboard/hp') diff --git a/src/mainboard/hp/folio_9480m/gpio.c b/src/mainboard/hp/folio_9480m/gpio.c index cb32f4f733..016ac76c59 100644 --- a/src/mainboard/hp/folio_9480m/gpio.c +++ b/src/mainboard/hp/folio_9480m/gpio.c @@ -2,7 +2,7 @@ #include -const struct pch_lp_gpio_map mainboard_gpio_map[] = { +const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = { [0] = { .conf0 = GPIO_MODE_GPIO | GPIO_DIR_INPUT | GPIO_IRQ_LEVEL }, [1] = { .conf0 = GPIO_MODE_GPIO | GPIO_DIR_INPUT | GPIO_INVERT | GPIO_IRQ_LEVEL }, [2] = LP_GPIO_OUT_LOW, -- cgit v1.2.3