From c97802fd4a9bc837bf4fe1d31e639283a43a15d2 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 1 Jan 2020 21:27:43 +0100 Subject: HP sandy/ivy laptops: Align devicetrees This makes it easier to spot differences. Change-Id: I16596a661ee4e56c2cb1d0aef663067ae6159705 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/38084 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/mainboard/hp/revolve_810_g1/devicetree.cb | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) (limited to 'src/mainboard/hp/revolve_810_g1') diff --git a/src/mainboard/hp/revolve_810_g1/devicetree.cb b/src/mainboard/hp/revolve_810_g1/devicetree.cb index 1866a1eae0..129de70284 100644 --- a/src/mainboard/hp/revolve_810_g1/devicetree.cb +++ b/src/mainboard/hp/revolve_810_g1/devicetree.cb @@ -31,7 +31,7 @@ chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did register "gpu_panel_power_up_delay" = "300" register "gpu_pch_backlight" = "0x02880288" device cpu_cluster 0x0 on - chip cpu/intel/model_206ax # FIXME: check all registers + chip cpu/intel/model_206ax register "c1_acpower" = "1" register "c1_battery" = "1" register "c2_acpower" = "3" @@ -45,9 +45,9 @@ chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did device domain 0x0 on subsystemid 0x103c 0x18f8 inherit - device pci 00.0 on end # Host bridge Host bridge + device pci 00.0 on end # Host bridge device pci 01.0 off end # PCIe Bridge for discrete graphics - device pci 02.0 on end # Internal graphics VGA controller + device pci 02.0 on end # Internal graphics chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH register "c2_latency" = "0x0065" @@ -62,11 +62,11 @@ chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did register "pcie_port_coalesce" = "1" register "sata_interface_speed_support" = "0x3" register "sata_port_map" = "0x1" - register "spi_lvscc" = "0x0" register "spi_uvscc" = "0x2005" + register "spi_lvscc" = "0" register "superspeed_capable_ports" = "0x0000000f" register "xhci_overcurrent_mapping" = "0x00000c03" - register "xhci_switchable_ports" = "0x0000000f" + register "xhci_switchable_ports" = "0x0000000f" device pci 14.0 on end # USB 3.0 Controller device pci 16.0 off end # Management Engine Interface 1 @@ -75,7 +75,7 @@ chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did device pci 16.3 off end # Management Engine KT device pci 19.0 on end # Intel Gigabit Ethernet device pci 1a.0 on end # USB2 EHCI #2 - device pci 1b.0 on end # High Definition Audio Audio controller + device pci 1b.0 on end # HD Audio controller device pci 1c.0 on end # PCIe Port #1 device pci 1c.1 off end # PCIe Port #2 device pci 1c.2 on end # PCIe Port #3 @@ -86,15 +86,14 @@ chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did device pci 1c.7 off end # PCIe Port #8 device pci 1d.0 on end # USB2 EHCI #1 device pci 1e.0 off end # PCI bridge - device pci 1f.0 on # LPC bridge PCI-LPC bridge + device pci 1f.0 on # LPC bridge chip ec/hp/kbc1126 register "ec_data_port" = "0x62" - register "ec_cmd_port" = "0x66" - register "ec_ctrl_reg" = "0x81" + register "ec_cmd_port" = "0x66" + register "ec_ctrl_reg" = "0x81" register "ec_fan_ctrl_value" = "0x70" device pnp ff.1 off end - end # kbc1126 - + end chip drivers/pc80/tpm device pnp 0c31.0 on end end -- cgit v1.2.3