From f903ef1d5f90728fac9d6772d9c33f9c5ed1501c Mon Sep 17 00:00:00 2001 From: Reka Norman Date: Mon, 21 Nov 2022 15:01:02 +1100 Subject: mb/google/nissa/var/nivviks,yaviks: Remove ISH firmware-name For nissa, the ISH main firmware will be included in the CSE region in flash instead of loading it from rootfs. So remove the ISH firmware-name. BUG=b:234776154 TEST=Boot to OS on nirwen and yaviks UFS SKUs. Check ISH firmware is not loaded by kernel, and device still goes to S0i3. Cq-Depend: chrome-internal:5102230 Change-Id: I68f963e17bc0dbf9db9adaaa3f96f06b8737523b Signed-off-by: Reka Norman Reviewed-on: https://review.coreboot.org/c/coreboot/+/69868 Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) Reviewed-by: Kangheui Won --- src/mainboard/google/brya/variants/nivviks/overridetree.cb | 4 ---- src/mainboard/google/brya/variants/yaviks/overridetree.cb | 7 +------ 2 files changed, 1 insertion(+), 10 deletions(-) (limited to 'src/mainboard/google') diff --git a/src/mainboard/google/brya/variants/nivviks/overridetree.cb b/src/mainboard/google/brya/variants/nivviks/overridetree.cb index 9567d4fdad..76fe43e71c 100644 --- a/src/mainboard/google/brya/variants/nivviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/nivviks/overridetree.cb @@ -519,10 +519,6 @@ chip soc/intel/alderlake probe STORAGE STORAGE_EMMC end device ref ish on - chip drivers/intel/ish - register "firmware_name" = ""adl_ish_lite.bin"" - device generic 0 on end - end probe STORAGE STORAGE_UFS end device ref ufs on diff --git a/src/mainboard/google/brya/variants/yaviks/overridetree.cb b/src/mainboard/google/brya/variants/yaviks/overridetree.cb index c3b98b57b5..6b57adae33 100644 --- a/src/mainboard/google/brya/variants/yaviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/yaviks/overridetree.cb @@ -212,12 +212,7 @@ chip soc/intel/alderlake end end device ref emmc on end - device ref ish on - chip drivers/intel/ish - register "firmware_name" = ""adl_ish_lite.bin"" - device generic 0 on end - end - end + device ref ish on end device ref ufs on end device ref pch_espi on chip ec/google/chromeec -- cgit v1.2.3