From 27c2ab694dd3a1d79f8c419cdaf9764dfd5db5be Mon Sep 17 00:00:00 2001 From: Nicolas Boichat Date: Mon, 12 Mar 2018 09:08:15 +0800 Subject: mb/google/poppy: Clear memory_params before initializing them Make sure that fields that are not updated in variant_memory_params keep a default value of 0. In particular, use_sec_spd is intended to have a default value of 0 on all platforms. Without this patch, a random value is used and all boards (except nami) get stuck on boot. BRANCH=poppy BUG=b:74439917 TEST=Nautilus and poppy can boot, and do not get stuck at "CBFS: 'sec-spd.bin' not found." Change-Id: I06c6511625de930903ae13788bdcd27667a17886 Signed-off-by: Nicolas Boichat Reviewed-on: https://review.coreboot.org/25101 Reviewed-by: Aaron Durbin Reviewed-by: Furquan Shaikh Tested-by: build bot (Jenkins) --- src/mainboard/google/poppy/romstage.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/mainboard/google') diff --git a/src/mainboard/google/poppy/romstage.c b/src/mainboard/google/poppy/romstage.c index f9b23e501a..f49fbf423f 100644 --- a/src/mainboard/google/poppy/romstage.c +++ b/src/mainboard/google/poppy/romstage.c @@ -147,6 +147,7 @@ void mainboard_memory_init_params(FSPM_UPD *mupd) FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig; struct memory_params p; + memset(&p, 0, sizeof(p)); variant_memory_params(&p); assert(p.type < MEMORY_COUNT); -- cgit v1.2.3