From 1ab202795532cdce155e42738d84e77a3e77ceb2 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Mon, 26 May 2014 17:38:23 +1000 Subject: Intel: Add common header file for CAR setup When passing '-ffreestanding' the 'main' romstage.c may no longer necessarily be considered the entry point. From the C specification in 5.1.2.1 Freestanding environment; "In a freestanding environment (in which C program execution may take place without any benefit of an operating system), the name and type of the function called at program startup are implementation-defined." Clang complains about these being missing as Clang is somewhat more strict about the spec than GNU/GCC is. An advantage here is that a different entry-point type-signature shall now be warned about at compile time. Change-Id: I467001adabd47958c30c9a15e3248e42ed1151f3 Signed-off-by: Edward O'Callaghan Reviewed-on: http://review.coreboot.org/5872 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- src/mainboard/google/butterfly/romstage.c | 1 + src/mainboard/google/link/romstage.c | 1 + src/mainboard/google/parrot/romstage.c | 1 + src/mainboard/google/stout/romstage.c | 1 + 4 files changed, 4 insertions(+) (limited to 'src/mainboard/google') diff --git a/src/mainboard/google/butterfly/romstage.c b/src/mainboard/google/butterfly/romstage.c index d946ea338d..1c7b8baf28 100644 --- a/src/mainboard/google/butterfly/romstage.c +++ b/src/mainboard/google/butterfly/romstage.c @@ -112,6 +112,7 @@ static void rcba_config(void) RCBA32(FD) = reg32; } +#include void main(unsigned long bist) { int boot_mode = 0; diff --git a/src/mainboard/google/link/romstage.c b/src/mainboard/google/link/romstage.c index 18c833ad38..25c65298a9 100644 --- a/src/mainboard/google/link/romstage.c +++ b/src/mainboard/google/link/romstage.c @@ -150,6 +150,7 @@ static void copy_spd(struct pei_data *peid) sizeof(peid->spd_data[0])); } +#include void main(unsigned long bist) { int boot_mode = 0; diff --git a/src/mainboard/google/parrot/romstage.c b/src/mainboard/google/parrot/romstage.c index 45cf7fef2a..a4daae5ab6 100644 --- a/src/mainboard/google/parrot/romstage.c +++ b/src/mainboard/google/parrot/romstage.c @@ -113,6 +113,7 @@ static void rcba_config(void) RCBA32(FD) = reg32; } +#include void main(unsigned long bist) { int boot_mode = 0; diff --git a/src/mainboard/google/stout/romstage.c b/src/mainboard/google/stout/romstage.c index 0e29b332df..008f1f8361 100644 --- a/src/mainboard/google/stout/romstage.c +++ b/src/mainboard/google/stout/romstage.c @@ -154,6 +154,7 @@ static void early_ec_init(void) } } +#include void main(unsigned long bist) { int boot_mode = 0; -- cgit v1.2.3