From 1a8eb6c02103727431ac1ea23f4f507e49f3cde7 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Wed, 17 Aug 2022 16:13:35 +0530 Subject: mb/google/rex: Create 64MB AP Firmware binary for Proto 0 This patch provides a mitigation path for having different size SPINOR parts across Rex board revisions. Rex Proto 0 only has 64MB SPINOR mounted on the board, and the plan is to use 32MB later with Proto 1 onwards. Hence, the idea here is to maintain a 32MB SPI Flash layout across all Rex board revisions, but the Proto 0 build only selects BOARD_ROMSIZE_KB_65536 config for adding padding at the end of the 32MB range. BUG=b:242825380 TEST=Able to create 64MB AP Firmware for Rex with below layout: SI_ALL: 0-9MB SI_BIOS: 9MB-32MB Padding/Unused: 32MB-64MB Additionally, able to hit CPU reset on MTLRVP (has 64MB SPINOR) with Rex AP Firmware binary. Signed-off-by: Subrata Banik Change-Id: Ibcc2206456639ef4ff22e0c4069521e583be58cd Reviewed-on: https://review.coreboot.org/c/coreboot/+/66828 Reviewed-by: Tarun Tuli Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal Reviewed-by: Ivy Jian Reviewed-by: Eric Lai --- src/mainboard/google/rex/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/mainboard/google') diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index 90c4c2c89a..fdcf8bb2d6 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -1,6 +1,8 @@ config BOARD_GOOGLE_REX_COMMON def_bool n - select BOARD_ROMSIZE_KB_32768 + # FIXME: Rex Proto 0 only has 64MB SPINOR mounted on the board, + # and the plan is to use 32MB later with Proto 1 onwards. + select BOARD_ROMSIZE_KB_65536 select EC_GOOGLE_CHROMEEC_BOARDID select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES -- cgit v1.2.3