From 167ccc7e65b251c3b735f82ce0675a6f85e157a8 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Sat, 29 Apr 2023 07:42:45 +0300 Subject: mainboard/*: Drop USB power control bits in GNVS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There is no platform-level implementation for USB port power management in various sleepstates. The mainboards changed here never evaluate the set GNVS variables S3U0, S3U1, S5U0 and S5U1 in ASL or in their SMI handlers. Change-Id: Ia1bc5969804a7346caac4ae93336efd9f0240c87 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/74858 Tested-by: build bot (Jenkins) Reviewed-by: Frans Hendriks Reviewed-by: Arthur Heymans Reviewed-by: Erik van den Bogaert --- src/mainboard/google/beltino/acpi_tables.c | 8 -------- src/mainboard/google/jecht/acpi_tables.c | 6 ------ 2 files changed, 14 deletions(-) (limited to 'src/mainboard/google') diff --git a/src/mainboard/google/beltino/acpi_tables.c b/src/mainboard/google/beltino/acpi_tables.c index 33f4b6bf3d..83e3165eef 100644 --- a/src/mainboard/google/beltino/acpi_tables.c +++ b/src/mainboard/google/beltino/acpi_tables.c @@ -8,14 +8,6 @@ void mainboard_fill_gnvs(struct global_nvs *gnvs) { - /* Enable USB ports in S3 */ - gnvs->s3u0 = 1; - gnvs->s3u1 = 1; - - /* Disable USB ports in S5 */ - gnvs->s5u0 = 0; - gnvs->s5u1 = 0; - /* TPM Present */ gnvs->tpmp = 1; diff --git a/src/mainboard/google/jecht/acpi_tables.c b/src/mainboard/google/jecht/acpi_tables.c index 189f7f44de..bc8ce27ce1 100644 --- a/src/mainboard/google/jecht/acpi_tables.c +++ b/src/mainboard/google/jecht/acpi_tables.c @@ -9,12 +9,6 @@ void mainboard_fill_gnvs(struct global_nvs *gnvs) { - /* Enable USB ports in S3 */ - gnvs->s3u0 = 1; - - /* Disable USB ports in S5 */ - gnvs->s5u0 = 0; - gnvs->tmps = TEMPERATURE_SENSOR_ID; gnvs->tcrt = CRITICAL_TEMPERATURE; gnvs->tpsv = PASSIVE_TEMPERATURE; -- cgit v1.2.3