From 11734053fb62e9d531449995271aeb295133c0da Mon Sep 17 00:00:00 2001 From: Tarun Tuli Date: Wed, 21 Jun 2023 19:41:17 +0000 Subject: mb/google/brya/acpi: Set power down delay to 2ms after PEXVDD Reduce the delay between PEXVDD and NVVDD from 3ms to 2ms during power down sequences. The hardware discharge is aggressive enough that we can safely optimize this. BUG=b:288267305 TEST=build and measured delay is acceptable Signed-off-by: Tarun Tuli Change-Id: I7c65301414044487e50bbbca618c4e602e571cfb Reviewed-on: https://review.coreboot.org/c/coreboot/+/76051 Reviewed-by: Nick Vaccaro Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/mainboard/google/brya/acpi/power.asl | 4 ++-- src/mainboard/google/brya/variants/hades/variant.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/mainboard/google') diff --git a/src/mainboard/google/brya/acpi/power.asl b/src/mainboard/google/brya/acpi/power.asl index a51bcaa3e6..7eb31d8f3b 100644 --- a/src/mainboard/google/brya/acpi/power.asl +++ b/src/mainboard/google/brya/acpi/power.asl @@ -140,7 +140,7 @@ Method (GC6I, 0, Serialized) #if CONFIG(BOARD_GOOGLE_AGAH) Sleep (10) #else - Sleep (3) + Sleep (2) #endif /* Deassert EN_PPVAR_GPU_NVVDD */ @@ -290,7 +290,7 @@ Method (PGOF, 0, Serialized) #if CONFIG(BOARD_GOOGLE_AGAH) Sleep (10) #else - Sleep (3) + Sleep (2) #endif /* Ramp down NVVDD */ diff --git a/src/mainboard/google/brya/variants/hades/variant.c b/src/mainboard/google/brya/variants/hades/variant.c index 0864ec007f..48e2652e8e 100644 --- a/src/mainboard/google/brya/variants/hades/variant.c +++ b/src/mainboard/google/brya/variants/hades/variant.c @@ -61,7 +61,7 @@ static struct power_rail_sequence gpu_on_seq[] = { /* In GCOFF entry order (i.e., power-off order) */ static struct power_rail_sequence gpu_off_seq[] = { { "FBVDD", FBVDD_PWR_EN, false, FBVDD_PG, 0,}, - { "PEXVDD", PEXVDD_PWR_EN, false, PEXVDD_PG, 3,}, + { "PEXVDD", PEXVDD_PWR_EN, false, PEXVDD_PG, 2,}, { "NVVDD+MSVDD", NVVDD_PWR_EN, false, NVVDD_PG, 2,}, { "GPU 3.3V", GPU_3V3_PWR_EN, false, GPU_3V3_PG, 4,}, { "GPU 1.8V", GPU_1V8_PWR_EN, false, GPU_1V8_PG, 0,}, -- cgit v1.2.3