From 774073dd0f97d42f040ec8230c7383e4bfe955ff Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Mon, 24 Aug 2020 18:37:15 +0000 Subject: Reland "mb/google/zork: Revert Don't expose reset GPIO for touchscreen to OS" This reverts commit 81066b7ce7192432389578fc0f15b3a46da84bad. Reason for revert: The hang observed when not exposing the reset GPIOs was root caused to zork sharing the same I2C bus between touchscreen and touchpad and interleaving of messages during probe which resulted in incorrect information returned back by touchscreen firmware. Exposing the reset GPIO changed the timing of probe and hence helped workaround the hang issue. The touchscreen driver is now fixed to perform I2C transactions in a single transfer and so the hang is no longer observed when reset GPIO isn't exposed. BUG=b:162596241 BRANCH=zork Signed-off-by: Furquan Shaikh Change-Id: Ica11c33d542dd2324bb0b8905c5de06047cee301 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44752 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel Reviewed-by: Aaron Durbin --- src/mainboard/google/zork/variants/berknip/overridetree.cb | 1 + 1 file changed, 1 insertion(+) (limited to 'src/mainboard/google/zork/variants/berknip') diff --git a/src/mainboard/google/zork/variants/berknip/overridetree.cb b/src/mainboard/google/zork/variants/berknip/overridetree.cb index aa248b682f..bdda034267 100644 --- a/src/mainboard/google/zork/variants/berknip/overridetree.cb +++ b/src/mainboard/google/zork/variants/berknip/overridetree.cb @@ -73,6 +73,7 @@ chip soc/amd/picasso # 20ms: Firmware ready time register "reset_delay_ms" = "32 + 20" register "has_power_resource" = "1" + register "disable_gpio_export_in_crs" = "1" device i2c 39 on end end chip drivers/i2c/generic -- cgit v1.2.3