From 6bbf16d5d29b05f86d4f21d43471c803db96328e Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Mon, 20 Mar 2023 10:59:04 -0600 Subject: mb/google/skyrim: Delete PSPP TODO Because Mendocino doesn't support PCIe Gen4, PSPP on this platform does not save any power, so leave it disabled. BUG=273889287 TEST=None BRANCH=skyrim Signed-off-by: Martin Roth Change-Id: I1a1c6692cd0a44469a35582042b92eeec31073fa Reviewed-on: https://review.coreboot.org/c/coreboot/+/73826 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian Reviewed-by: Elyes Haouas Reviewed-by: Fred Reitberger Reviewed-by: Felix Held --- src/mainboard/google/skyrim/variants/baseboard/devicetree.cb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/mainboard/google/skyrim/variants/baseboard/devicetree.cb') diff --git a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb index 6892742050..202ab265ba 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb @@ -79,7 +79,8 @@ chip soc/amd/mendocino register "gpp_clk_config[2]" = "GPP_CLK_REQ" register "gpp_clk_config[3]" = "GPP_CLK_OFF" - register "pspp_policy" = "DXIO_PSPP_DISABLED" # TODO: reenable when PSPP works + # PSPP doesn't save any power on this platform + register "pspp_policy" = "DXIO_PSPP_DISABLED" register "s0ix_enable" = "true" -- cgit v1.2.3