From a254cc6672c38cdb7f18294f3f11359d4b6e76d1 Mon Sep 17 00:00:00 2001 From: Zhongtian Wu Date: Thu, 7 Sep 2023 20:19:43 +0800 Subject: mb/google/rex/var/screebo: Change GPP_C06 to NC GPP_C06 is the report pin of the touchpanel and has no actual function. Disable this pin to solve the leakage problem. BUG=b:298529441 BRANCH=none TEST=Test success by EE. Change-Id: I13f25788c0258639da4e277e7a15454a08d1599b Signed-off-by: Zhongtian Wu Reviewed-on: https://review.coreboot.org/c/coreboot/+/77716 Reviewed-by: Subrata Banik Reviewed-by: Eric Lai Reviewed-by: Kapil Porwal Tested-by: build bot (Jenkins) --- src/mainboard/google/rex/variants/screebo/gpio.c | 4 ++-- src/mainboard/google/rex/variants/screebo/overridetree.cb | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) (limited to 'src/mainboard/google/rex/variants') diff --git a/src/mainboard/google/rex/variants/screebo/gpio.c b/src/mainboard/google/rex/variants/screebo/gpio.c index 8ca890416c..314022ee0f 100644 --- a/src/mainboard/google/rex/variants/screebo/gpio.c +++ b/src/mainboard/google/rex/variants/screebo/gpio.c @@ -107,8 +107,8 @@ static const struct pad_config gpio_table[] = { PAD_NC(GPP_C04, NONE), /* GPP_C05 : [] ==> WWAN_PERST_L_STRAP */ PAD_NC(GPP_C05, NONE), - /* GPP_C06 : [] ==> SOC_TCHSCR_RPT_EN */ - PAD_CFG_GPO(GPP_C06, 0, DEEP), + /* GPP_C06 : net NC. Test pad. */ + PAD_NC(GPP_C06, NONE), /* GPP_C07 : [] ==> SOC_TCHSCR_INT */ PAD_CFG_GPI_APIC(GPP_C07, NONE, PLTRST, LEVEL, NONE), /* GPP_C08 : [] ==> SOCHOT_ODL */ diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb index f14c09d668..f5f491f258 100644 --- a/src/mainboard/google/rex/variants/screebo/overridetree.cb +++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb @@ -427,8 +427,6 @@ chip soc/intel/meteorlake register "generic.reset_delay_ms" = "200" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B17)" register "generic.enable_delay_ms" = "12" - register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C06)" - register "generic.stop_off_delay_ms" = "2" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 41 on @@ -445,8 +443,6 @@ chip soc/intel/meteorlake register "generic.reset_off_delay_ms" = "2" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B17)" register "generic.enable_delay_ms" = "1" - register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C06)" - register "generic.stop_off_delay_ms" = "2" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 10 on -- cgit v1.2.3