From 474a7c51cecfd2e37b315da9cfb25607f3ad84f1 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Tue, 7 Feb 2017 22:07:56 -0600 Subject: google/rambi: add explicit pull-down for ram-id Some variants need the internal pull resistor on GPIO_SSUS_40 set explicitly to pull down rather than disabling the pull, in order for the ram-id to be read correctly via GPIO. Correct this by adding a function to enable and set the internal pull and define its use as needed in the board's variant.h. Chromium source: branch: firmware-gnawty-5216.239.B /src/soc/intel/baytrail/baytrail/gpio.h#418 /src/mainboard/google/gnawty/romstage.c#60 Test: boot 4GB Candy board and observe correct RAM id, amount detected Change-Id: I8823c27385f4422184b5afa57f6048f7ff2a25ab Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/18309 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Paul Menzel --- src/mainboard/google/rambi/variants/candy/include/variant/variant.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/mainboard/google/rambi/variants/candy') diff --git a/src/mainboard/google/rambi/variants/candy/include/variant/variant.h b/src/mainboard/google/rambi/variants/candy/include/variant/variant.h index 0c58ceefa2..fe4c475825 100644 --- a/src/mainboard/google/rambi/variants/candy/include/variant/variant.h +++ b/src/mainboard/google/rambi/variants/candy/include/variant/variant.h @@ -38,5 +38,6 @@ static const uint32_t dual_channel_config = #define GPIO_SSUS_38_PAD 50 #define GPIO_SSUS_39_PAD 58 #define GPIO_SSUS_40_PAD 52 +#define GPIO_SSUS_40_PAD_USE_PULLDOWN #endif -- cgit v1.2.3