From fa06bcba06c5842faae797629e9f72ec28d511c0 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 26 Dec 2022 09:32:47 +0100 Subject: mainboard/acpi: Replace constant "Zero" with actual number Change-Id: I4f2f02623b060ef0ebefc5aceb713c77a8b1e9a6 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/71523 Reviewed-by: Elyes Haouas Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- .../variants/atlas/include/variant/acpi/cam0.asl | 4 ++-- .../baseboard/include/baseboard/acpi/cam0.asl | 6 +++--- .../baseboard/include/baseboard/acpi/cam1.asl | 2 +- .../include/baseboard/acpi/camera_pmic.asl | 22 +++++++++++----------- .../nautilus/include/variant/acpi/cam0.asl | 6 +++--- .../nocturne/include/variant/acpi/cam0.asl | 4 ++-- .../nocturne/include/variant/acpi/cam1.asl | 2 +- 7 files changed, 23 insertions(+), 23 deletions(-) (limited to 'src/mainboard/google/poppy') diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl index 4809f26df9..959ec4a2f9 100644 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl @@ -47,7 +47,7 @@ Scope (\_SB.PCI0.I2C3) Device (CAM0) { Name (_HID, "INT3478") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "SONY IMX208 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -109,7 +109,7 @@ Scope (\_SB.PCI0.I2C3) Device (NVM0) { Name (_HID, "INT3499") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "GT24C16S") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl index 2d5dd0a289..6ad59f1a0f 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl @@ -5,7 +5,7 @@ Scope (\_SB.PCI0.I2C2) Device (CAM0) { Name (_HID, "OVTID858") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "OV 13858 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02) @@ -92,7 +92,7 @@ Scope (\_SB.PCI0.I2C2) Device (VCM0) { Name (_HID, "PRP0001") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ Name (CAMD, 0x03) @@ -124,7 +124,7 @@ Scope (\_SB.PCI0.I2C2) Device (NVM0) { Name (_HID, "INT3499") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "GT24C16S/CAT24C16") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl index c41ebca7fe..974f1c4e23 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl @@ -5,7 +5,7 @@ Scope (\_SB.PCI0.I2C4) Device (CAM1) { Name (_HID, "INT3479") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "OV 5670 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02) diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl index d588d575dc..5825d77565 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl @@ -5,7 +5,7 @@ Scope (\_SB.PCI0.I2C2) Device (PMIC) { Name (_HID, "INT3472") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "TPS68470 PMIC") /* _DDN: DOS Device Name */ Name (CAMD, 0x64) @@ -56,12 +56,12 @@ Scope (\_SB.PCI0.I2C2) } /* Marks the availability of all the operation regions */ - Name (AVBL, Zero) - Name (AVGP, Zero) - Name (AVB0, Zero) - Name (AVB1, Zero) - Name (AVB2, Zero) - Name (AVB3, Zero) + Name (AVBL, 0) + Name (AVGP, 0) + Name (AVB0, 0) + Name (AVB1, 0) + Name (AVB2, 0) + Name (AVB3, 0) Method (_REG, 2, NotSerialized) { If (Arg0 == 0x08) @@ -244,7 +244,7 @@ Scope (\_SB.PCI0.I2C2) * VACT: Analog LDO output * VDCT: Core buck output */ - OperationRegion (PWR1, 0xB0, Zero, 0x0100) + OperationRegion (PWR1, 0xB0, 0, 0x0100) Field (PWR1, DWordAcc, NoLock, Preserve) { VSIO, 32, @@ -264,7 +264,7 @@ Scope (\_SB.PCI0.I2C2) * ACVA: Analog LDO VR voltage * DCVA: Core buck VR voltage */ - OperationRegion (PWR2, 0xB1, Zero, 0x0100) + OperationRegion (PWR2, 0xB1, 0, 0x0100) Field (PWR2, DWordAcc, NoLock, Preserve) { SIOV, 32, @@ -282,7 +282,7 @@ Scope (\_SB.PCI0.I2C2) * CFG1: Clock configuration 1 register * CFG2: Clock configuration 2 register */ - OperationRegion (CLKC, 0xB2, Zero, 0x0100) + OperationRegion (CLKC, 0xB2, 0, 0x0100) Field (CLKC, DWordAcc, NoLock, Preserve) { PCTL, 32, @@ -300,7 +300,7 @@ Scope (\_SB.PCI0.I2C2) * PLDV: PLL feedback divider * PODV: PLL output divider for HCLK_A */ - OperationRegion (CLKF, 0xB3, Zero, 0x0100) + OperationRegion (CLKF, 0xB3, 0, 0x0100) Field (CLKF, DWordAcc, NoLock, Preserve) { PDV2, 32, diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl index cfc84b5334..8d662ea504 100644 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl @@ -5,7 +5,7 @@ Scope (\_SB.PCI0.I2C2) Device (CAM0) { Name (_HID, "SONY258A") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "SONY IMX258 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -73,7 +73,7 @@ Scope (\_SB.PCI0.I2C2) Device (VCM0) { Name (_HID, "PRP0001") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -104,7 +104,7 @@ Scope (\_SB.PCI0.I2C2) Device (NVM0) { Name (_HID, "INT3499") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Dongwoon NVM") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl index c3449a7f66..e5cf437f6b 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl @@ -41,7 +41,7 @@ Scope (\_SB.PCI0.I2C3) Device (CAM0) { Name (_HID, "SONY319A") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Sony IMX319 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -104,7 +104,7 @@ Scope (\_SB.PCI0.I2C3) Device (NVM0) { Name (_HID, "INT3499") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "M24C64S") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl index 0e31eee538..8337cc5afd 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl @@ -40,7 +40,7 @@ Scope (\_SB.PCI0.I2C5) Device (CAM1) { Name (_HID, "SONY355A") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ + Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "SONY IMX355A Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ -- cgit v1.2.3