From 8b400b8c64bb42e479a4f9666cc0fb0ba9428af7 Mon Sep 17 00:00:00 2001 From: Caveh Jalali Date: Fri, 1 Feb 2019 21:15:37 -0800 Subject: Revert "mb/google/poppy/variant/atlas: I2C: run trackpad at 1MHz" This reverts commit 7696290004b6490c7ef8027d7ddf67b163e7dad8. We're seeing trackpad problems on some units with the I2C bus running at 1MHz but not at 400KHz. So, revert back to 400KHz until we understand how to make 1MHz operation more robust. BUG=b:123650686 Change-Id: Ifb06afece9eee0c153240d35e6c3001f5b74f310 Signed-off-by: Caveh Jalali Reviewed-on: https://review.coreboot.org/c/31212 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh --- src/mainboard/google/poppy/variants/atlas/devicetree.cb | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'src/mainboard/google/poppy') diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index f8a6e6d601..275b27d065 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -207,15 +207,14 @@ chip soc/intel/skylake .fall_time_ns = 38, }, .i2c[2] = { - .speed = I2C_SPEED_FAST_PLUS, + .speed = I2C_SPEED_FAST, .speed_config[0] = { - .speed = I2C_SPEED_FAST_PLUS, - .scl_lcnt = 69, - .scl_hcnt = 33, - .sda_hold = 20, - } + .speed = I2C_SPEED_FAST, + .scl_lcnt = 186, + .scl_hcnt = 93, + .sda_hold = 36, + }, }, - .i2c[3] = { .speed = I2C_SPEED_FAST, .rise_time_ns = 98, @@ -296,7 +295,6 @@ chip soc/intel/skylake register "generic.hid" = ""ACPI0C50"" register "generic.desc" = ""ELAN Touchpad"" register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_A19_IRQ)" - register "generic.speed" = "I2C_SPEED_FAST_PLUS" register "generic.wake" = "GPE0_DW0_23" # GPP_A23 register "hid_desc_reg_offset" = "0x01" device i2c 0x15 on end -- cgit v1.2.3