From 567b4ee0b9abcbbc66cd912461f027953919b725 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Fri, 5 Jan 2018 20:24:20 -0800 Subject: mb/google/poppy: Add internal pull-up on pen eject signal Since the current hardware revision does not have external pull on the pen eject signal, this change adds internal pull-up on it. Change-Id: I426d9833d7efbd8735b6f2b4896d1012b62cb4b8 Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/23143 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Tony Lin Reviewed-by: Aaron Durbin --- src/mainboard/google/poppy/variants/baseboard/gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/mainboard/google/poppy') diff --git a/src/mainboard/google/poppy/variants/baseboard/gpio.c b/src/mainboard/google/poppy/variants/baseboard/gpio.c index a6b9af0437..8b9a21b55a 100644 --- a/src/mainboard/google/poppy/variants/baseboard/gpio.c +++ b/src/mainboard/google/poppy/variants/baseboard/gpio.c @@ -177,7 +177,7 @@ static const struct pad_config gpio_table[] = { /* D7 : ISH_I2C1_SDA ==> NC */ PAD_CFG_NC(GPP_D7), /* D8 : ISH_I2C1_SCL ==> PEN_EJECT_ODL -- for notification */ - PAD_CFG_GPI(GPP_D8, NONE, PLTRST), + PAD_CFG_GPI(GPP_D8, 20K_PU, PLTRST), /* D9 : ISH_SPI_CS# ==> HP_IRQ_GPIO */ PAD_CFG_GPI_GPIO_DRIVER(GPP_D9, NONE, PLTRST), /* D10 : ISH_SPI_CLK ==> SPKR_RST_L */ @@ -185,7 +185,7 @@ static const struct pad_config gpio_table[] = { /* D11 : ISH_SPI_MISO ==> SPKR_INT_L */ PAD_CFG_GPI_APIC(GPP_D11, NONE, PLTRST), /* D12 : ISH_SPI_MOSI ==> PEN_EJECT_ODL -- for wake event */ - PAD_CFG_GPI_ACPI_SCI(GPP_D12, NONE, DEEP, INVERT), + PAD_CFG_GPI_ACPI_SCI(GPP_D12, 20K_PU, DEEP, INVERT), /* D13 : ISH_UART0_RXD ==> NC */ PAD_CFG_NC(GPP_D13), /* D14 : ISH_UART0_TXD ==> NC */ -- cgit v1.2.3