From 6afeef829f1a47aa8817275ae1bac2fb46bea18a Mon Sep 17 00:00:00 2001 From: Shamile Khan Date: Thu, 10 Jan 2019 18:46:02 -0800 Subject: mb/google/octopus: Fix termination for unused dual voltage pins These pins should not have pull downs configured in standby state as that can cause contention on the termination circuitry and lead to incorrect behavior as per Doc# 572688 Gemini Lake Processor GPIOTermination Configuration. BUG=b:79982669 TEST=Checked that code compiles with changes. Change-Id: If3cadc000ec6fc56019ee3f57e556dc819d5e0a5 Signed-off-by: Shamile Khan Reviewed-on: https://review.coreboot.org/c/30823 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh --- src/mainboard/google/octopus/variants/casta/gpio.c | 6 +++--- src/mainboard/google/octopus/variants/fleex/gpio.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src/mainboard/google/octopus') diff --git a/src/mainboard/google/octopus/variants/casta/gpio.c b/src/mainboard/google/octopus/variants/casta/gpio.c index 1746e4ff6b..fcb7ab5d56 100644 --- a/src/mainboard/google/octopus/variants/casta/gpio.c +++ b/src/mainboard/google/octopus/variants/casta/gpio.c @@ -27,11 +27,11 @@ static const struct pad_config default_override_table[] = { PAD_NC(GPIO_67, UP_20K), /* EN_PP3300_DX_LTE_SOC -- unused */ - PAD_NC(GPIO_105, DN_20K), /* TOUCHSCREEN_RST -- unused */ + PAD_NC(GPIO_105, UP_20K), /* TOUCHSCREEN_RST -- unused */ PAD_NC(GPIO_108, NONE), /* PMU_SUSCLK -- unused */ - PAD_NC(GPIO_114, DN_20K), /* I2C7 Touchscreen -- unused */ - PAD_NC(GPIO_115, DN_20K), /* I2C7 Touchscreen -- unused */ + PAD_NC(GPIO_114, UP_20K), /* I2C7 Touchscreen -- unused */ + PAD_NC(GPIO_115, UP_20K), /* I2C7 Touchscreen -- unused */ PAD_NC(GPIO_117, UP_20K), /* PCIE_WAKE1_B - No LTE*/ PAD_NC(GPIO_119, UP_20K), /* PCIE_WAKE3_B - only use CNVI */ diff --git a/src/mainboard/google/octopus/variants/fleex/gpio.c b/src/mainboard/google/octopus/variants/fleex/gpio.c index b1f377b32b..6bb78aa373 100644 --- a/src/mainboard/google/octopus/variants/fleex/gpio.c +++ b/src/mainboard/google/octopus/variants/fleex/gpio.c @@ -28,8 +28,8 @@ static const struct pad_config default_override_table[] = { PAD_NC(GPIO_67, UP_20K), PAD_NC(GPIO_117, UP_20K), - PAD_NC(GPIO_138, DN_20K), - PAD_NC(GPIO_139, DN_20K), + PAD_NC(GPIO_138, UP_20K), + PAD_NC(GPIO_139, UP_20K), PAD_NC(GPIO_140, UP_20K), PAD_NC(GPIO_143, UP_20K), PAD_NC(GPIO_144, UP_20K), -- cgit v1.2.3