From 54c2cc1b29a9b2e1a80f5b32d46914a4a801fe67 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Fri, 29 Jun 2018 11:17:03 -0700 Subject: mb/google/*: Remove selection of DRIVERS_PS2_KEYBOARD Until now, chromeec was doing keyboard initialization for the boards that have DRIVERS_PS2_KEYBOARD selected. However, coreboot does not leave the keyboard controller in a default reset state. This could result in payloads or OS failing to probe the controller as there could be stale data buffered in the controller during the handoff. Since the boards using chromeec already perform keyboard initialization in payload, there is no need to initialize the keyboard in coreboot too. This change gets rid of DRIVERS_PS2_KEYBOARD selection from all google mainboards using chromeec. BUG=b:110024487 TEST=Keyboard works fine after booting to OS even if user hits keys during BIOS to OS handoff. Change-Id: I1f49b060eb005c0f2b86f9d68d6758954eeb3cf0 Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/27291 Reviewed-by: Aaron Durbin Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/mainboard/google/octopus/Kconfig | 1 - 1 file changed, 1 deletion(-) (limited to 'src/mainboard/google/octopus') diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 4b2a8f8aef..34ca725a3f 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -7,7 +7,6 @@ config BOARD_GOOGLE_BASEBOARD_OCTOPUS select DRIVERS_I2C_DA7219 select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID - select DRIVERS_PS2_KEYBOARD select DRIVERS_SPI_ACPI select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_BOARDID -- cgit v1.2.3