From ae2cf495084325c6f4a0cb87b96167def77a80cc Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Wed, 21 Nov 2018 14:02:59 -0800 Subject: mb/google/octopus: Update GPIO_178 in early_gpio_table in baseboard This change updates the configuration of GPIO_178 to be active low as per latest revision on different octopus variants. This effectively: 1. Gets rid of early_gpio_table in different variants -- phaser, meep, fleex, bobba. 2. Deprecates board id < 2 for bobba, board id < 1 for fleex and phaser. 3. Adds special early_gpio_table in yorp which has GPIO_178 as an active high signal. BUG=b:119885949 Change-Id: I024199a8f1f96db57f8fa60c4d265789cd3a0493 Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/c/29784 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian Reviewed-by: Aaron Durbin Reviewed-by: Justin TerAvest --- src/mainboard/google/octopus/variants/meep/gpio.c | 36 ----------------------- 1 file changed, 36 deletions(-) (limited to 'src/mainboard/google/octopus/variants/meep/gpio.c') diff --git a/src/mainboard/google/octopus/variants/meep/gpio.c b/src/mainboard/google/octopus/variants/meep/gpio.c index 823224c808..7e572875c3 100644 --- a/src/mainboard/google/octopus/variants/meep/gpio.c +++ b/src/mainboard/google/octopus/variants/meep/gpio.c @@ -38,39 +38,3 @@ const struct pad_config *variant_override_gpio_table(size_t *num) *num = ARRAY_SIZE(default_override_table); return default_override_table; } - -/* GPIOs needed prior to ramstage. */ -static const struct pad_config early_gpio_table[] = { - /* PCH_WP_OD */ - PAD_CFG_GPI(GPIO_190, NONE, DEEP), - /* H1_PCH_INT_ODL */ - PAD_CFG_GPI_APIC_IOS(GPIO_63, NONE, DEEP, LEVEL, INVERT, TxDRxE, - DISPUPD), - /* H1_SLAVE_SPI_CLK_R */ - PAD_CFG_NF(GPIO_79, NONE, DEEP, NF1), - /* H1_SLAVE_SPI_CS_L_R */ - PAD_CFG_NF(GPIO_80, NONE, DEEP, NF1), - /* H1_SLAVE_SPI_MISO */ - PAD_CFG_NF(GPIO_82, NONE, DEEP, NF1), - /* H1_SLAVE_SPI_MOSI_R */ - PAD_CFG_NF(GPIO_83, NONE, DEEP, NF1), - - PAD_CFG_GPO(GPIO_178, 0, DEEP), - - /* WLAN_PE_RST */ - PAD_CFG_GPO(GPIO_164, 0, DEEP), - - /* - * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak - * pull-up for proper operation. Since there is no external pull present - * on this platform, configure an internal weak pull-up. - */ - PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_151, UP_20K, DEEP, NF2, HIZCRx1, - ENPU), -}; - -const struct pad_config *variant_early_gpio_table(size_t *num) -{ - *num = ARRAY_SIZE(early_gpio_table); - return early_gpio_table; -} -- cgit v1.2.3