From 5db62ef94aaa6d9aa1b4d56494a5e95f06d5eb2e Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 15 Apr 2021 01:04:06 +0200 Subject: mb/google/guybrush,mancomb: only print warning in mainboard_smi_gpi guybrush and mancomb don't configure any GPIO as PAD_SMI. Since mainboard_smi_gpi will only get called for a GEVENT that will cause a non-SCI SMI, this isn't expected to be called. For the unexpected and very unlikely case that it still does get called, put a printk into mainboard_smi_gpi to see what is happening there. TEST=none Signed-off-by: Felix Held Change-Id: Ifd6e3348ecc078932bf6cf5b0830b4b034d274bb Reviewed-on: https://review.coreboot.org/c/coreboot/+/52360 Reviewed-by: Angel Pons Reviewed-by: Marshall Dawson Tested-by: build bot (Jenkins) --- src/mainboard/google/mancomb/smihandler.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/mainboard/google/mancomb/smihandler.c') diff --git a/src/mainboard/google/mancomb/smihandler.c b/src/mainboard/google/mancomb/smihandler.c index 6facb76476..04280db316 100644 --- a/src/mainboard/google/mancomb/smihandler.c +++ b/src/mainboard/google/mancomb/smihandler.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include +#include #include #include #include @@ -9,7 +10,8 @@ void mainboard_smi_gpi(u32 gpi_sts) { - chromeec_smi_process_events(); + printk(BIOS_WARNING, "No GPIO is set up as PAD_SMI, so %s should never end up being " + "called. gpi_status is %x.\n", __func__, gpi_sts); } void mainboard_smi_sleep(u8 slp_typ) -- cgit v1.2.3