From 333751b22e046793d84d72d1053b9c6aa2854d77 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 23 Jun 2021 14:39:32 +0200 Subject: broadwell: Compute channel disable masks at runtime Introduce the `SPD_MEMORY_DOWN` macro to indicate that a slot is used with memory-down. This enables computing the channel disable masks as the bits for slots where the SPD address is zero. To preserve current behavior, zero the SPD addresses for memory-down slots afterwards. Change-Id: I75b7be7c72062d1a26cfc7b09b79de62de0a9cea Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/55807 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/google/jecht/spd/spd.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/mainboard/google/jecht/spd') diff --git a/src/mainboard/google/jecht/spd/spd.c b/src/mainboard/google/jecht/spd/spd.c index 942b9a33e9..6446a937e1 100644 --- a/src/mainboard/google/jecht/spd/spd.c +++ b/src/mainboard/google/jecht/spd/spd.c @@ -8,8 +8,6 @@ void mainboard_fill_spd_data(struct pei_data *pei_data) { pei_data->spd_addresses[0] = 0xa0; pei_data->spd_addresses[2] = 0xa4; - pei_data->dimm_channel0_disabled = 2; - pei_data->dimm_channel1_disabled = 2; // Enable 2x refresh mode pei_data->ddr_refresh_2x = 1; pei_data->dq_pins_interleaved = 1; -- cgit v1.2.3