From 68d8357dab55660058ad1ab8dca34fd03e0adbb5 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Mon, 19 Apr 2021 22:31:49 +0200 Subject: soc/intel/broadwell/pch: Replace ACPI device NVS The same functionality can be provided through a runtime-generated SSDT. The remaining parts of device NVS are removed in a follow-up. Since the SSDTs are only loaded after the DSDT (if loaded at all), using SSDT-provided objects outside method bodies is not possible: the objects are not yet in OSPM's ACPI namespace, which causes in ACPI errors. Owing to this, the operation regions used by the _PS0 and _PS3 methods need to be moved into the SSDT, as they depend on the SSDT-provided BAR1 values. Tested on out-of-tree Compal LA-A992P, generated SSDT disassembles with no errors and contains expected values. Linux does not complain either. Change-Id: I89fb658fbb10a8769ebea2e6535c45cd7c212d06 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/52520 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak --- src/mainboard/google/jecht/dsdt.asl | 1 - 1 file changed, 1 deletion(-) (limited to 'src/mainboard/google/jecht/dsdt.asl') diff --git a/src/mainboard/google/jecht/dsdt.asl b/src/mainboard/google/jecht/dsdt.asl index 220caee144..3f7b9ae4fc 100644 --- a/src/mainboard/google/jecht/dsdt.asl +++ b/src/mainboard/google/jecht/dsdt.asl @@ -19,7 +19,6 @@ DefinitionBlock( // global NVS and variables #include - #include // CPU #include -- cgit v1.2.3