From 76fddd9639250db8af486188a5ba39291006af8a Mon Sep 17 00:00:00 2001 From: Rob Barnes Date: Tue, 12 Apr 2022 14:07:09 -0600 Subject: mb/google/nipperkin: Disable PSPP for WLAN Disable PSPP parameters for WLAN card on Nipperkin. This feature is causing S0ix resume hangs. BUG=b:227296841,b:228830362 BRANCH=guybrush TEST=Suspend stress test passes on Nipperkin Signed-off-by: Rob Barnes Change-Id: I38f05b92ace4aba61163194a6a638915882b8871 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63593 Reviewed-by: Raul Rangel Reviewed-by: Karthik Ramasubramanian Reviewed-by: Felix Held Tested-by: build bot (Jenkins) --- src/mainboard/google/guybrush/variants/nipperkin/variant.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/mainboard/google/guybrush') diff --git a/src/mainboard/google/guybrush/variants/nipperkin/variant.c b/src/mainboard/google/guybrush/variants/nipperkin/variant.c index 204ec61b55..9ffb2d5389 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/variant.c +++ b/src/mainboard/google/guybrush/variants/nipperkin/variant.c @@ -4,6 +4,7 @@ #include #include #include +#include void variant_update_dxio_descriptors(fsp_dxio_descriptor *dxio_descriptors) { @@ -12,6 +13,9 @@ void variant_update_dxio_descriptors(fsp_dxio_descriptor *dxio_descriptors) if (board_version >= 3) { dxio_descriptors[WLAN].link_aspm_L1_1 = true; dxio_descriptors[WLAN].link_aspm_L1_2 = true; + /* Disable PSPP to avoid S0ix hangs - b/228830362 */ + memset(dxio_descriptors[WLAN].port_params, 0, + sizeof(dxio_descriptors[WLAN].port_params)); } else { dxio_descriptors[WLAN].link_aspm_L1_1 = false; dxio_descriptors[WLAN].link_aspm_L1_2 = false; -- cgit v1.2.3