From 27a1c924e2bf47b07f838cff381f6c0cb05b2afe Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 8 May 2023 19:42:20 +0200 Subject: mb/google/gru: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: Id7f9b598cc9df51ddf664b851172cc96a710c580 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/75023 Reviewed-by: Martin L Roth Tested-by: build bot (Jenkins) --- src/mainboard/google/gru/Kconfig | 18 ++++++++++++++++++ src/mainboard/google/gru/Kconfig.name | 6 ------ 2 files changed, 18 insertions(+), 6 deletions(-) (limited to 'src/mainboard/google/gru') diff --git a/src/mainboard/google/gru/Kconfig b/src/mainboard/google/gru/Kconfig index 23926b65d9..837b06d403 100644 --- a/src/mainboard/google/gru/Kconfig +++ b/src/mainboard/google/gru/Kconfig @@ -3,6 +3,24 @@ config BOARD_GOOGLE_GRU_COMMON # Umbrella option to be selected by variant boards. def_bool n +config BOARD_GOOGLE_KEVIN + select BOARD_GOOGLE_GRU_COMMON + +config BOARD_GOOGLE_GRU + select BOARD_GOOGLE_GRU_COMMON + +config BOARD_GOOGLE_BOB + select BOARD_GOOGLE_GRU_COMMON + +config BOARD_GOOGLE_SCARLET + select BOARD_GOOGLE_GRU_COMMON + +config BOARD_GOOGLE_NEFARIO + select BOARD_GOOGLE_GRU_COMMON + +config BOARD_GOOGLE_RAINIER + select BOARD_GOOGLE_GRU_COMMON + if BOARD_GOOGLE_GRU_COMMON # Most Grus have TPM2 but later Kevins don't... decide this in one place for diff --git a/src/mainboard/google/gru/Kconfig.name b/src/mainboard/google/gru/Kconfig.name index 04571c888b..5d8f2158d0 100644 --- a/src/mainboard/google/gru/Kconfig.name +++ b/src/mainboard/google/gru/Kconfig.name @@ -2,24 +2,18 @@ comment "Gru" config BOARD_GOOGLE_KEVIN bool "-> Kevin (Samsung Chromebook Plus)" - select BOARD_GOOGLE_GRU_COMMON config BOARD_GOOGLE_GRU bool "-> Gru" - select BOARD_GOOGLE_GRU_COMMON config BOARD_GOOGLE_BOB bool "-> Bob (Asus Chromebook Flip C101PA)" - select BOARD_GOOGLE_GRU_COMMON config BOARD_GOOGLE_SCARLET bool "-> Scarlet" - select BOARD_GOOGLE_GRU_COMMON config BOARD_GOOGLE_NEFARIO bool "-> Nefario" - select BOARD_GOOGLE_GRU_COMMON config BOARD_GOOGLE_RAINIER bool "-> Rainier" - select BOARD_GOOGLE_GRU_COMMON -- cgit v1.2.3