From e3f564988b7d893bfe681f3f93bb2a89d36f9b01 Mon Sep 17 00:00:00 2001 From: Karthikeyan Ramasubramanian Date: Fri, 15 May 2020 11:04:39 -0600 Subject: mb/google/dedede: Enable Intel Speed Shift Technology Enable Intel Speed Shift Technology (ISST) by default. Disable ISST in waddledee and waddledoo variants on early phases. BUG=b:151281860 TEST=Build and boot the mainboard. Ensure that cpufreq driver to configure P-states is enabled in kernel on boards where board version is provisioned. Change-Id: Id65d7981501c2f282e564bfc140f8d499d5713e8 Signed-off-by: Karthikeyan Ramasubramanian Reviewed-on: https://review.coreboot.org/c/coreboot/+/39477 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh Reviewed-by: Aamir Bohra Reviewed-by: Sumeet R Pawnikar --- .../google/dedede/variants/waddledee/Makefile.inc | 2 ++ src/mainboard/google/dedede/variants/waddledee/variant.c | 16 ++++++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 src/mainboard/google/dedede/variants/waddledee/variant.c (limited to 'src/mainboard/google/dedede/variants/waddledee') diff --git a/src/mainboard/google/dedede/variants/waddledee/Makefile.inc b/src/mainboard/google/dedede/variants/waddledee/Makefile.inc index dfb97bae95..aaa65e2a2a 100644 --- a/src/mainboard/google/dedede/variants/waddledee/Makefile.inc +++ b/src/mainboard/google/dedede/variants/waddledee/Makefile.inc @@ -4,3 +4,5 @@ SPD_SOURCES = SPD_LPDDR4X_200b_8Gb_4267_DDP_1x16 #0b0000 SPD_SOURCES += empty #0b0001 romstage-y += memory.c + +ramstage-y += variant.c diff --git a/src/mainboard/google/dedede/variants/waddledee/variant.c b/src/mainboard/google/dedede/variants/waddledee/variant.c new file mode 100644 index 0000000000..ac3cf581d9 --- /dev/null +++ b/src/mainboard/google/dedede/variants/waddledee/variant.c @@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include +#include +#include +#include + +void variant_isst_override(void) +{ + config_t *cfg = config_of_soc(); + uint32_t board_ver; + + /* Override/Disable ISST in boards where board version is not populated. */ + if (google_chromeec_get_board_version(&board_ver)) + cfg->speed_shift_enable = 0; +} -- cgit v1.2.3