From a2bc2540c2d004b475b401ccf0b162c2452857bb Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Sat, 29 May 2021 08:10:49 +0200 Subject: Allow to build romstage sources inside the bootblock Having a separate romstage is only desirable: - with advanced setups like vboot or normal/fallback - boot medium is slow at startup (some ARM SOCs) - bootblock is limited in size (Intel APL 32K) When this is not the case there is no need for the extra complexity that romstage brings. Including the romstage sources inside the bootblock substantially reduces the total code footprint. Often the resulting code is 10-20k smaller. This is controlled via a Kconfig option. TESTED: works on qemu x86, arm and aarch64 with and without VBOOT. Change-Id: Id68390edc1ba228b121cca89b80c64a92553e284 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/55068 Reviewed-by: Julius Werner Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- src/mainboard/google/daisy/romstage.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/mainboard/google/daisy') diff --git a/src/mainboard/google/daisy/romstage.c b/src/mainboard/google/daisy/romstage.c index d9ae00cced..4fa2b3bb9f 100644 --- a/src/mainboard/google/daisy/romstage.c +++ b/src/mainboard/google/daisy/romstage.c @@ -118,6 +118,7 @@ static struct mem_timings *setup_clock(void) return mem; } +#if CONFIG(SEPARATE_ROMSTAGE) void main(void) { timestamp_init(timestamp_get()); @@ -126,10 +127,11 @@ void main(void) /* * From the clocks comment below it looks like serial console won't * work in the bootblock so keep in the romstage_main flow even with - * !CONFIG SEPARATE_ROMSTAGE. + * !CONFIG(SEPARATE_ROMSTAGE). */ romstage_main(); } +#endif void __noreturn romstage_main(void) { -- cgit v1.2.3