From f2fc4972282bfa92be417bc6f3df3197c47ceb01 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Tue, 3 Oct 2017 15:39:22 -0500 Subject: google/cyan: fix variant memory/silicon init params override The mainboard_memory_init_params() and mainboard_silicon_init_params() methods already have weak definitions in drivers/intel/fsp1_1, so having them declared as weak in the cyan baseboard has the effect of them not being called at all unless overridden at the variant level. Therefore, remove the weak declarations in the baseboard and ensure that each variant has its own init functions if needed. TEST: build/boot google/cyan Change-Id: I1c76cb5838ef1e65e72c7341d951f9baf2ddd41b Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/21704 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/mainboard/google/cyan/variants/banon/romstage.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) (limited to 'src/mainboard/google/cyan/variants/banon') diff --git a/src/mainboard/google/cyan/variants/banon/romstage.c b/src/mainboard/google/cyan/variants/banon/romstage.c index dab80b0cef..e516bb8446 100644 --- a/src/mainboard/google/cyan/variants/banon/romstage.c +++ b/src/mainboard/google/cyan/variants/banon/romstage.c @@ -15,11 +15,10 @@ */ #include -#include +#include #include -void mainboard_memory_init_params(struct romstage_params *params, - MEMORY_INIT_UPD *memory_params) +void variant_memory_init_params(MEMORY_INIT_UPD *memory_params) { int ram_id = get_ramid(); @@ -45,10 +44,4 @@ void mainboard_memory_init_params(struct romstage_params *params, memory_params->PcdDramDensity = 3; memory_params->PcdDualRankDram = 0; } - - /* Update SPD data */ - memory_params->PcdMemoryTypeEnable = MEM_LPDDR3; - memory_params->PcdMemorySpdPtr = (u32)params->pei_data->spd_data_ch0; - memory_params->PcdMemChannel0Config = params->pei_data->spd_ch0_config; - memory_params->PcdMemChannel1Config = params->pei_data->spd_ch1_config; } -- cgit v1.2.3