From 4ae5873e7f056d1996b181d72ef50f2972bdccae Mon Sep 17 00:00:00 2001 From: Reka Norman Date: Mon, 12 Dec 2022 10:36:19 +1100 Subject: mb/google/nissa/var/nivviks,yaviks: Add DmaProperty for ISH On nissa, the ISH is running closed source firmware, so the ChromeOS security requirements specify it must be behind an IOMMU. Add DmaProperty to the ISH _DSD on nivviks and yaviks. BUG=b:259716145 TEST=Kernel marks ISH (PCI device 12.0) as untrusted, and changes the IOMMU group type to "DMA". Also, device still goes to S0i3. Before: $ cat /sys/devices/pci0000\:00/0000\:00\:12.0/untrusted 0 $ ls /sys/kernel/iommu_groups/5/devices 0000:00:12.0 0000:00:12.7 $ cat /sys/kernel/iommu_groups/5/type DMA-FQ After: $ cat /sys/devices/pci0000\:00/0000\:00\:12.0/untrusted 1 $ ls /sys/kernel/iommu_groups/5/devices 0000:00:12.0 0000:00:12.7 $ cat /sys/kernel/iommu_groups/5/type DMA Change-Id: Iaddb24580bda77df0c70ff58eb098213f8b509ad Signed-off-by: Reka Norman Reviewed-on: https://review.coreboot.org/c/coreboot/+/70633 Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik Reviewed-by: Kangheui Won Reviewed-by: Eric Lai --- src/mainboard/google/brya/variants/nivviks/overridetree.cb | 4 ++++ src/mainboard/google/brya/variants/yaviks/overridetree.cb | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletion(-) (limited to 'src/mainboard/google/brya') diff --git a/src/mainboard/google/brya/variants/nivviks/overridetree.cb b/src/mainboard/google/brya/variants/nivviks/overridetree.cb index 76fe43e71c..f9b8430ec8 100644 --- a/src/mainboard/google/brya/variants/nivviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/nivviks/overridetree.cb @@ -519,6 +519,10 @@ chip soc/intel/alderlake probe STORAGE STORAGE_EMMC end device ref ish on + chip drivers/intel/ish + register "add_acpi_dma_property" = "true" + device generic 0 on end + end probe STORAGE STORAGE_UFS end device ref ufs on diff --git a/src/mainboard/google/brya/variants/yaviks/overridetree.cb b/src/mainboard/google/brya/variants/yaviks/overridetree.cb index 6c58e4eb7e..3ad4ff3523 100644 --- a/src/mainboard/google/brya/variants/yaviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/yaviks/overridetree.cb @@ -212,7 +212,12 @@ chip soc/intel/alderlake end end device ref emmc on end - device ref ish on end + device ref ish on + chip drivers/intel/ish + register "add_acpi_dma_property" = "true" + device generic 0 on end + end + end device ref ufs on end device ref pch_espi on chip ec/google/chromeec -- cgit v1.2.3