From 235c603a330b35418efd562990c7f37fa169f64c Mon Sep 17 00:00:00 2001 From: Jayvik Desai Date: Mon, 23 Sep 2024 14:18:54 +0530 Subject: mb/google/brya: enable config DRIVER_INTEL_ISH_HAS_MAIN_FW for trulo Trulo ISH uses the MAIN FW loaded by the kernel driver. This commit enables DRIVER_INTEL_ISH_HAS_MAIN_FW for trulo, which skips printing the ISH BUP version. BUG=b:360144613 TEST=Local build successful and tested on trulo by toggling the config. enabling this config skips printing the ISH version in cbmem. 1. CONFIG enabled ``` trulo-rev1 ~ # cbmem -c | grep ISH [INFO ] \_SB.PCI0.ISHB: Set firmware-name: ish_fw.bin ``` 2. CONFIG disabled ``` trulo-rev1 ~ # cbmem -c | grep ISH [DEBUG] ISH version: 5.4.2.36864 [INFO ] \_SB.PCI0.ISHB: Set firmware-name: ish_fw.bin ``` Change-Id: Ifebd563ec8ddb0378e1215a90396687857f3f71d Signed-off-by: Jayvik Desai Reviewed-on: https://review.coreboot.org/c/coreboot/+/84494 Reviewed-by: Eric Lai Reviewed-by: Dinesh Gehlot Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik --- src/mainboard/google/brya/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/mainboard/google/brya') diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 5088ade027..5f1e6b9b86 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -111,13 +111,13 @@ config BOARD_GOOGLE_BASEBOARD_TRULO select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if CHROMEOS select DRIVERS_AUDIO_SOF select DRIVERS_INTEL_ISH + select DRIVER_INTEL_ISH_HAS_MAIN_FW select MAINBOARD_DISABLE_STAGE_CACHE select MAINBOARD_HAS_EARLY_LIBGFXINIT select MEMORY_SOLDERDOWN select SOC_INTEL_COMMON_MMC_OVERRIDE select SOC_INTEL_CSE_LITE_COMPRESS_ME_RW select SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE - select SOC_INTEL_STORE_ISH_FW_VERSION select SOC_INTEL_TWINLAKE select SYSTEM_TYPE_LAPTOP select TPM_GOOGLE_TI50 -- cgit v1.2.3