From 17c77f5a86abc9ac6d9cbae029a793dfe1c4b9cb Mon Sep 17 00:00:00 2001 From: Tim Wawrzynczak Date: Thu, 30 Jun 2022 10:19:58 -0600 Subject: mb/google/brya/var/agah: Disable ASPM for dGPU Since ASPM is not verified as fully functional yet, and the board is still in development, this patch disables ASPM for the dGPU. BUG=b:236676400 TEST=boot to OS in agah, lspci -vvv shows ASPM is disabled Signed-off-by: Tim Wawrzynczak Change-Id: I525eeb18c57d45fd55335b63a59262066afc9567 Reviewed-on: https://review.coreboot.org/c/coreboot/+/65566 Tested-by: build bot (Jenkins) Reviewed-by: Ivy Jian --- src/mainboard/google/brya/variants/agah/overridetree.cb | 1 + src/mainboard/google/brya/variants/agah/variant.c | 4 ++++ 2 files changed, 5 insertions(+) (limited to 'src/mainboard/google/brya/variants') diff --git a/src/mainboard/google/brya/variants/agah/overridetree.cb b/src/mainboard/google/brya/variants/agah/overridetree.cb index 550dab60fb..a50a9d4cb8 100644 --- a/src/mainboard/google/brya/variants/agah/overridetree.cb +++ b/src/mainboard/google/brya/variants/agah/overridetree.cb @@ -71,6 +71,7 @@ chip soc/intel/alderlake .clk_req = 0, .clk_src = 0, .flags = PCIE_RP_LTR | PCIE_RP_AER, + .pcie_rp_aspm = ASPM_DISABLE }" device pci 00.0 alias dgpu on end end diff --git a/src/mainboard/google/brya/variants/agah/variant.c b/src/mainboard/google/brya/variants/agah/variant.c index b0baab356b..437fdc4c51 100644 --- a/src/mainboard/google/brya/variants/agah/variant.c +++ b/src/mainboard/google/brya/variants/agah/variant.c @@ -132,6 +132,10 @@ static void dgpu_power_sequence_on(void) void variant_init(void) { + /* Disable ASPM for the GPU until it is verified working. */ + struct device *dgpu = DEV_PTR(dgpu); + dgpu->disable_pcie_aspm = 1; + if (acpi_is_wakeup_s3()) return; -- cgit v1.2.3