From bc1533e08975b285e589447f329ef25bfe585ef9 Mon Sep 17 00:00:00 2001 From: Won Chung Date: Thu, 27 Jul 2023 20:10:25 +0000 Subject: mb/google: Add more comment on GFX devices for the future reference Add more details to instruct future boards/models implementers regarding how GFX devices should be added. If HDMI and DP connectors are enumerated by the kernel in /sys/class/drm/ then corresponding GFX device should be added to ACPI. It is possible that some connectors do not have dedicated ports, but still enumerated. The order of GFX devices is DDIA -> DDIB -> TCPX. BUG=b:277629750 TEST=emerge-brya coreboot Change-Id: I59e82ee954a7d502e419046c1c2d7a20ea8a9224 Signed-off-by: Won Chung Reviewed-on: https://review.coreboot.org/c/coreboot/+/76776 Reviewed-by: Kapil Porwal Tested-by: build bot (Jenkins) Reviewed-by: Jakub Czapiga --- src/mainboard/google/brya/variants/brya0/overridetree.cb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/mainboard/google/brya/variants/brya0') diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb index 31d78a4a18..50fadbcef2 100644 --- a/src/mainboard/google/brya/variants/brya0/overridetree.cb +++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb @@ -122,6 +122,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD"" # DDIB for HDMI + # If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 register "device[2].name" = ""DD02"" @@ -135,7 +136,7 @@ chip soc/intel/alderlake register "device[4].name" = ""DD04"" register "device[4].use_pld" = "true" register "device[4].pld" = "ACPI_PLD_TYPE_C(LEFT, LEFT, ACPI_PLD_GROUP(3, 1))" - # TCP3 (DP-4) unused + # TCP3 (DP-4) is unused for any ports but still enumerated in the kernel, so GFX device is added for TCP3 register "device[5].name" = ""DD05"" device generic 0 on end end -- cgit v1.2.3