From 2f8a7046bb120d96022ada1e74545f859f97521f Mon Sep 17 00:00:00 2001 From: Tim Wawrzynczak Date: Tue, 18 May 2021 10:42:40 -0600 Subject: mb/google/brya/brya0: Manually probe fw_config for DB_LTE In order to use the USB WWAN module in USB mode (as opposed to PCIe), the PCIe RP must be turned off at the FSP level. The `probe` statement in the devicetree unfortunately takes effect too late, because the UPDs for disabling/enabling PCIE RP belong to FSP-M (romstage), whereas fw_config probing for devicetree is done in ramstage. Add a new variant-specific file which will handle manually setting the UPD based on FW_CONFIG instead. BUG=b:180166408 TEST=set CBI FW_CONFIG field to LTE_USB, see message in console, set field to LTE_PCIE, do not see message in console. Change-Id: Ica2f64ec99fa547e233012dc201577a14f6aa7d7 Signed-off-by: Tim Wawrzynczak Reviewed-on: https://review.coreboot.org/c/coreboot/+/54633 Reviewed-by: EricR Lai Tested-by: build bot (Jenkins) --- .../google/brya/variants/baseboard/include/baseboard/variants.h | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/mainboard/google/brya/variants/baseboard/include') diff --git a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h index fb105e806a..1d1fe83ec2 100644 --- a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h @@ -3,6 +3,7 @@ #ifndef __BASEBOARD_VARIANTS_H__ #define __BASEBOARD_VARIANTS_H__ +#include #include #include #include @@ -19,4 +20,6 @@ const struct mb_cfg *variant_memory_params(void); int variant_memory_sku(void); bool variant_is_half_populated(void); +void variant_update_fspm_upds(FSPM_UPD *memupd); + #endif /*__BASEBOARD_VARIANTS_H__ */ -- cgit v1.2.3