From a2d9afc5eaa0ddc337d3993ef21720045872fc26 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Fri, 18 Aug 2017 14:41:12 -0500 Subject: google/beltino: fix LED polarity for mccloud variant The LED polarity was set incorrectly, fix using values derived from original Chromium sources: branch firmware-mccloud-5827.B, ToT src/mainboard/google/mccloud/smihandler.c src/mainboard/google/mccloud/romstage.c TEST: boot google/mccloud, observe power LED on normally, blinking in S3/S4, and off in S5. Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/21102 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/mainboard/google/beltino/variants/mccloud/led.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/mainboard/google/beltino') diff --git a/src/mainboard/google/beltino/variants/mccloud/led.c b/src/mainboard/google/beltino/variants/mccloud/led.c index ce8d2d861c..b47e50a5a1 100644 --- a/src/mainboard/google/beltino/variants/mccloud/led.c +++ b/src/mainboard/google/beltino/variants/mccloud/led.c @@ -22,7 +22,7 @@ void set_power_led(int state) it8772f_gpio_led(IT8772F_GPIO_DEV, 1, /* set */ 0x01, /* select */ - state == LED_OFF ? 0x00 : 0x01, /* polarity */ + state == LED_BLINK ? 0x01 : 0x00, /* polarity */ state == LED_BLINK ? 0x01 : 0x00, /* pullup/pulldown */ 0x01, /* output */ state == LED_BLINK ? 0x00 : 0x01, /* I/O function */ -- cgit v1.2.3