From 8aab7876d186ed9a8e978ec06a83a46f74a6179b Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sat, 4 Jul 2020 01:24:59 +0200 Subject: haswell: Move some MRC settings to devicetree There's no generic way to tell whether a mainboard has an EC or not. Making Kconfig symbols for these options seems overkill, too. So, just put them on the devicetree. Also, drop unnecessary assignments when the board's current value is zero, as the struct defaults to zero already. Change-Id: If2ebac5fcab278c97dfaf8adc9d1e125888acafe Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/43129 Reviewed-by: Nico Huber Reviewed-by: Tristan Corrick Tested-by: build bot (Jenkins) --- src/mainboard/google/beltino/devicetree.cb | 4 ++++ src/mainboard/google/beltino/romstage.c | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src/mainboard/google/beltino') diff --git a/src/mainboard/google/beltino/devicetree.cb b/src/mainboard/google/beltino/devicetree.cb index f4c9e850ab..304f3cf38f 100644 --- a/src/mainboard/google/beltino/devicetree.cb +++ b/src/mainboard/google/beltino/devicetree.cb @@ -9,6 +9,10 @@ chip northbridge/intel/haswell # Enable HDMI Hotplug with 6ms pulse register "gpu_dp_b_hotplug" = "0x06" + register "dq_pins_interleaved" = "true" + + register "usb_xhci_on_resume" = "true" + device cpu_cluster 0 on chip cpu/intel/haswell device lapic 0 on end diff --git a/src/mainboard/google/beltino/romstage.c b/src/mainboard/google/beltino/romstage.c index 8410d04923..ee146301ec 100644 --- a/src/mainboard/google/beltino/romstage.c +++ b/src/mainboard/google/beltino/romstage.c @@ -48,10 +48,6 @@ void mb_get_spd_map(uint8_t spd_map[4]) void mainboard_fill_pei_data(struct pei_data *pei_data) { - pei_data->ec_present = 0; - pei_data->dq_pins_interleaved = 1; - pei_data->usb_xhci_on_resume = 1; - struct usb2_port_setting usb2_ports[MAX_USB2_PORTS] = { /* Length, Enable, OCn#, Location */ { 0x0064, 1, 0, /* P0: VP8 */ -- cgit v1.2.3