From ca83dc2309e144b60abed24c9a81927609ffe480 Mon Sep 17 00:00:00 2001 From: Nicholas Sudsgaard Date: Wed, 18 Sep 2024 14:11:53 +0000 Subject: mb/google: Correct number of jacks in hda_verb.c This corrects the mismatch found in the verb tables of Monroe Chromebase and Link Chromebook. The verb data was not aligned to a multiple of 4, therefore an entry was repeated as padding. This was found due to the `_Static_assert()` from CB:84360 failing. TEST=Tested on LINK under Linux and Win11, audio working properly under both. Change-Id: Id377281af310642a6ba77e5a0002ca1dfca38827 Signed-off-by: Nicholas Sudsgaard Reviewed-on: https://review.coreboot.org/c/coreboot/+/84414 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/google/beltino/variants/monroe/hda_verb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/mainboard/google/beltino/variants') diff --git a/src/mainboard/google/beltino/variants/monroe/hda_verb.c b/src/mainboard/google/beltino/variants/monroe/hda_verb.c index 064bebfeea..3b529e2682 100644 --- a/src/mainboard/google/beltino/variants/monroe/hda_verb.c +++ b/src/mainboard/google/beltino/variants/monroe/hda_verb.c @@ -6,7 +6,7 @@ const u32 cim_verb_data[] = { /* coreboot specific header */ 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 0x00000010, // Number of jacks (NID entries) 0x0017ff00, // Function Reset 0x0017ff00, // Double Function Reset -- cgit v1.2.3