From f9acd37d7f15290240d4fb9e365a7b79af57b925 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 20 Jan 2021 23:25:59 +0100 Subject: mb/google/auron: Use `get_gpios` function MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I91424a45ae67186987630b7686102f467f57e7ee Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/49779 Tested-by: build bot (Jenkins) Reviewed-by: Michael Niewöhner --- src/mainboard/google/auron/variants/samus/spd/spd.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) (limited to 'src/mainboard/google/auron/variants/samus') diff --git a/src/mainboard/google/auron/variants/samus/spd/spd.c b/src/mainboard/google/auron/variants/samus/spd/spd.c index 25ff928b6d..06270b8ebb 100644 --- a/src/mainboard/google/auron/variants/samus/spd/spd.c +++ b/src/mainboard/google/auron/variants/samus/spd/spd.c @@ -20,27 +20,15 @@ /* Copy SPD data for on-board memory */ void mainboard_fill_spd_data(struct pei_data *pei_data) { - int spd_bits[4] = { + const int gpio_vector[] = { SPD_GPIO_BIT0, SPD_GPIO_BIT1, SPD_GPIO_BIT2, - SPD_GPIO_BIT3 + SPD_GPIO_BIT3, + -1, }; - int spd_gpio[4]; - int spd_index; - spd_gpio[0] = get_gpio(spd_bits[0]); - spd_gpio[1] = get_gpio(spd_bits[1]); - spd_gpio[2] = get_gpio(spd_bits[2]); - spd_gpio[3] = get_gpio(spd_bits[3]); - - spd_index = (spd_gpio[3] << 3) | (spd_gpio[2] << 2) | - (spd_gpio[1] << 1) | spd_gpio[0]; - - printk(BIOS_DEBUG, "SPD: index %d (GPIO%d=%d GPIO%d=%d " - "GPIO%d=%d GPIO%d=%d)\n", spd_index, - spd_bits[3], spd_gpio[3], spd_bits[2], spd_gpio[2], - spd_bits[1], spd_gpio[1], spd_bits[0], spd_gpio[0]); + const unsigned int spd_index = get_gpios(gpio_vector); fill_spd_for_index(pei_data->spd_data[0][0], spd_index); -- cgit v1.2.3