From c76c59aa6a62ef2fb9fa7e97ac76156b6593e4c5 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Mon, 28 Jun 2021 14:00:57 +0200 Subject: QEMU: Only call `pci_assign_irqs` with non-NULL dev Do not call `pci_assign_irqs` with a NULL device pointer. Change-Id: Ide9ae38dedd881ed673ba1838a1e29529b306937 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/55900 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/mainboard/emulation/qemu-i440fx/mainboard.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'src/mainboard/emulation/qemu-i440fx') diff --git a/src/mainboard/emulation/qemu-i440fx/mainboard.c b/src/mainboard/emulation/qemu-i440fx/mainboard.c index 218c47f0aa..a7c6b32598 100644 --- a/src/mainboard/emulation/qemu-i440fx/mainboard.c +++ b/src/mainboard/emulation/qemu-i440fx/mainboard.c @@ -24,8 +24,11 @@ static void qemu_nb_init(struct device *dev) pc_keyboard_init(NO_AUX_DEVICE); /* setup IRQ routing */ - for (i = 0; i < 32; i++) - pci_assign_irqs(pcidev_on_root(i, 0), qemu_i440fx_irqs + (i % 4)); + for (i = 0; i < 32; i++) { + struct device *d = pcidev_on_root(i, 0); + if (d) + pci_assign_irqs(d, qemu_i440fx_irqs + (i % 4)); + } } static void qemu_nb_read_resources(struct device *dev) -- cgit v1.2.3