From 7b49c3711298c06f4293c6b31a16834e3e042423 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sun, 13 Nov 2022 12:48:44 +0100 Subject: mainboard: Drop invalid `hyper_threading` option MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Drop the `hyper_threading` CMOS option from most boards, as it's most likely not working properly and causing problems. The main reasons to remove the option are: * The used enum is backwards (0 ---> Enable, 1 ---> Disable) * Platform/SoC code does not honor the `hyper_threading` option Also, remove the now-unused enum used by the `hyper_threading` option. Change-Id: Ia8980a951f4751bc2e1a5d0e88835f578259b256 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/69523 Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) Reviewed-by: Sean Rhodes --- src/mainboard/bostentech/gbyt4/cmos.layout | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/mainboard/bostentech/gbyt4') diff --git a/src/mainboard/bostentech/gbyt4/cmos.layout b/src/mainboard/bostentech/gbyt4/cmos.layout index 018db314ac..2b8e1a223c 100644 --- a/src/mainboard/bostentech/gbyt4/cmos.layout +++ b/src/mainboard/bostentech/gbyt4/cmos.layout @@ -11,8 +11,6 @@ entries # ----------------------------------------------------------------- # coreboot config options: console 395 4 e 6 debug_level -# coreboot config options: cpu -400 1 e 2 hyper_threading # coreboot config options: southbridge 408 1 e 1 nmi 409 2 e 7 power_on_after_fail @@ -26,8 +24,6 @@ enumerations #ID value text 1 0 Disable 1 1 Enable -2 0 Enable -2 1 Disable 4 0 Fallback 4 1 Normal 6 0 Emergency -- cgit v1.2.3