From d225834220cfbe59850a97092674c4d55faff757 Mon Sep 17 00:00:00 2001 From: Peter Lemenkov Date: Thu, 26 Dec 2019 21:17:33 +0300 Subject: mb/*/*/acpi_tables: Don't initialize already initialized fields Don't initialize fields with zeroes since gnvs structs were zeroed out in southbridge already. See * src/southbridge/intel/*/lpc.c Change-Id: I5228f2cdc94df722ffa687c45b4e4fd25e82df82 Signed-off-by: Peter Lemenkov Reviewed-on: https://review.coreboot.org/c/coreboot/+/37967 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Rudolph Reviewed-by: Angel Pons --- src/mainboard/asus/p8h61-m_pro/acpi_tables.c | 8 -------- src/mainboard/asus/p8z77-m_pro/acpi_tables.c | 8 -------- 2 files changed, 16 deletions(-) (limited to 'src/mainboard/asus') diff --git a/src/mainboard/asus/p8h61-m_pro/acpi_tables.c b/src/mainboard/asus/p8h61-m_pro/acpi_tables.c index 3eadbfb0a2..23537a44d3 100644 --- a/src/mainboard/asus/p8h61-m_pro/acpi_tables.c +++ b/src/mainboard/asus/p8h61-m_pro/acpi_tables.c @@ -19,14 +19,6 @@ void acpi_create_gnvs(global_nvs_t *gnvs) { - /* Disable USB ports in S3 by default */ - gnvs->s3u0 = 0; - gnvs->s3u1 = 0; - - /* Disable USB ports in S5 by default */ - gnvs->s5u0 = 0; - gnvs->s5u1 = 0; - gnvs->tcrt = 100; gnvs->tpsv = 90; } diff --git a/src/mainboard/asus/p8z77-m_pro/acpi_tables.c b/src/mainboard/asus/p8z77-m_pro/acpi_tables.c index 2592c19a9e..2d03a99a3c 100644 --- a/src/mainboard/asus/p8z77-m_pro/acpi_tables.c +++ b/src/mainboard/asus/p8z77-m_pro/acpi_tables.c @@ -19,14 +19,6 @@ void acpi_create_gnvs(global_nvs_t *gnvs) { - /* Turn off power for USB ports in S3 by default */ - gnvs->s3u0 = 0; - gnvs->s3u1 = 0; - - /* Turn off power for USB ports in S5 by default */ - gnvs->s5u0 = 0; - gnvs->s5u1 = 0; - /* critical temp that will shutdown the pc == 95C degrees */ gnvs->tcrt = 95; -- cgit v1.2.3