From 2c0aa00d6e562b2e6dbe580e188e24ce5e4336e2 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Tue, 3 Nov 2020 00:03:32 +0100 Subject: mb/**/cmos.layout: Remove crusty comments Most of these comments have been copy-pasted or serve no purpose other than to eventually turn into misleading info. While the description of the first 120 bits of CMOS could be useful, it should instead be added to the documentation for the CMOS option infrastructure, or /dev/null. Moreover, trim down newlines to no more than two consecutive newlines. Change-Id: I119b248821221e68c4e31edba71ba83b7d2e14e9 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/47143 Tested-by: build bot (Jenkins) Reviewed-by: Frans Hendriks --- src/mainboard/asus/a88xm-e/cmos.layout | 1 - src/mainboard/asus/am1i-a/cmos.layout | 1 - src/mainboard/asus/f2a85-m/cmos.layout | 1 - src/mainboard/asus/h61m-cs/cmos.layout | 27 ------------------------ src/mainboard/asus/maximus_iv_gene-z/cmos.layout | 22 ------------------- src/mainboard/asus/p5gc-mx/cmos.layout | 7 ------ src/mainboard/asus/p5qc/cmos.layout | 23 -------------------- src/mainboard/asus/p5ql-em/cmos.layout | 5 ----- src/mainboard/asus/p5qpl-am/cmos.layout | 25 ---------------------- src/mainboard/asus/p8h61-m_lx/cmos.layout | 22 ------------------- src/mainboard/asus/p8h61-m_pro/cmos.layout | 27 ------------------------ src/mainboard/asus/p8z77-m_pro/cmos.layout | 22 ------------------- 12 files changed, 183 deletions(-) (limited to 'src/mainboard/asus') diff --git a/src/mainboard/asus/a88xm-e/cmos.layout b/src/mainboard/asus/a88xm-e/cmos.layout index 2355292411..fa85c710b3 100644 --- a/src/mainboard/asus/a88xm-e/cmos.layout +++ b/src/mainboard/asus/a88xm-e/cmos.layout @@ -5,7 +5,6 @@ entries 0 384 r 0 reserved_memory 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#392 3 r 0 unused 395 1 e 1 hw_scrubber 396 1 e 1 interleave_chip_selects 397 2 e 8 max_mem_clock diff --git a/src/mainboard/asus/am1i-a/cmos.layout b/src/mainboard/asus/am1i-a/cmos.layout index 9f9ee80faa..c00b1c67eb 100644 --- a/src/mainboard/asus/am1i-a/cmos.layout +++ b/src/mainboard/asus/am1i-a/cmos.layout @@ -9,7 +9,6 @@ entries 0 384 r 0 reserved_memory 384 1 e 4 boot_option 388 4 r 0 reboot_counter -#392 3 r 0 unused #400 1 e 1 power_on_after_fail 412 4 e 6 debug_level 416 4 e 7 boot_first diff --git a/src/mainboard/asus/f2a85-m/cmos.layout b/src/mainboard/asus/f2a85-m/cmos.layout index ade4c04bf3..18bac8ee34 100644 --- a/src/mainboard/asus/f2a85-m/cmos.layout +++ b/src/mainboard/asus/f2a85-m/cmos.layout @@ -8,7 +8,6 @@ entries 0 384 r 0 reserved_memory 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#392 3 r 0 unused 395 1 e 1 hw_scrubber 396 1 e 1 interleave_chip_selects 397 2 e 8 max_mem_clock diff --git a/src/mainboard/asus/h61m-cs/cmos.layout b/src/mainboard/asus/h61m-cs/cmos.layout index 1860a78326..0913b6d66d 100644 --- a/src/mainboard/asus/h61m-cs/cmos.layout +++ b/src/mainboard/asus/h61m-cs/cmos.layout @@ -3,55 +3,28 @@ # ----------------------------------------------------------------- entries -# ----------------------------------------------------------------- -# Status Register A -# ----------------------------------------------------------------- -# Status Register B -# ----------------------------------------------------------------- -# Status Register C -#96 4 r 0 status_c_rsvd -#100 1 r 0 uf_flag -#101 1 r 0 af_flag -#102 1 r 0 pf_flag -#103 1 r 0 irqf_flag -# ----------------------------------------------------------------- -# Status Register D -#104 7 r 0 status_d_rsvd -#111 1 r 0 valid_cmos_ram -# ----------------------------------------------------------------- -# Diagnostic Status Register -#112 8 r 0 diag_rsvd1 - # ----------------------------------------------------------------- 0 120 r 0 reserved_memory -#120 264 r 0 unused # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#390 2 r 0 unused? # ----------------------------------------------------------------- # coreboot config options: console -#392 3 r 0 unused 395 4 e 6 debug_level -#399 1 r 0 unused # coreboot config options: southbridge 408 1 e 1 nmi 409 2 e 7 power_on_after_fail -#411 10 r 0 unused 421 1 e 9 sata_mode -#422 2 r 0 unused # coreboot config options: cpu -#425 7 r 0 unused # coreboot config options: northbridge 432 3 e 11 gfx_uma_size -#435 549 r 0 unused # coreboot config options: check sums 984 16 h 0 check_sum diff --git a/src/mainboard/asus/maximus_iv_gene-z/cmos.layout b/src/mainboard/asus/maximus_iv_gene-z/cmos.layout index c8c53e745c..d3ce21948a 100644 --- a/src/mainboard/asus/maximus_iv_gene-z/cmos.layout +++ b/src/mainboard/asus/maximus_iv_gene-z/cmos.layout @@ -3,28 +3,8 @@ # ----------------------------------------------------------------- entries -# ----------------------------------------------------------------- -# Status Register A -# ----------------------------------------------------------------- -# Status Register B -# ----------------------------------------------------------------- -# Status Register C -#96 4 r 0 status_c_rsvd -#100 1 r 0 uf_flag -#101 1 r 0 af_flag -#102 1 r 0 pf_flag -#103 1 r 0 irqf_flag -# ----------------------------------------------------------------- -# Status Register D -#104 7 r 0 status_d_rsvd -#111 1 r 0 valid_cmos_ram -# ----------------------------------------------------------------- -# Diagnostic Status Register -#112 8 r 0 diag_rsvd1 - # ----------------------------------------------------------------- 0 120 r 0 reserved_memory -#120 264 r 0 unused # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) @@ -33,9 +13,7 @@ entries # ----------------------------------------------------------------- # coreboot config options: console -#392 3 r 0 unused 395 4 e 4 debug_level -#399 1 r 0 unused #400 8 r 0 reserved for century byte diff --git a/src/mainboard/asus/p5gc-mx/cmos.layout b/src/mainboard/asus/p5gc-mx/cmos.layout index a7c4b7dba7..356f38ec6f 100644 --- a/src/mainboard/asus/p5gc-mx/cmos.layout +++ b/src/mainboard/asus/p5gc-mx/cmos.layout @@ -3,22 +3,17 @@ # ----------------------------------------------------------------- entries 0 120 r 0 reserved_memory -#120 264 r 0 unused # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#390 2 r 0 unused # ----------------------------------------------------------------- # coreboot config options: console -#392 3 r 0 unused 395 4 e 6 debug_level -#399 1 r 0 unused # coreboot config options: cpu -#401 7 r 0 unused # coreboot config options: southbridge 408 1 e 1 nmi @@ -28,11 +23,9 @@ entries # coreboot config options: bootloader 416 512 s 0 boot_devices -#928 80 r 0 unused # coreboot config options: check sums 984 16 h 0 check_sum -#1000 24 r 0 amd_reserved # RAM initialization internal data 1024 8 r 0 C0WL0REOST diff --git a/src/mainboard/asus/p5qc/cmos.layout b/src/mainboard/asus/p5qc/cmos.layout index 3e8d5f0a77..cd00074c9c 100644 --- a/src/mainboard/asus/p5qc/cmos.layout +++ b/src/mainboard/asus/p5qc/cmos.layout @@ -3,34 +3,13 @@ # ----------------------------------------------------------------- entries -# ----------------------------------------------------------------- -# Status Register A -# ----------------------------------------------------------------- -# Status Register B -# ----------------------------------------------------------------- -# Status Register C -#96 4 r 0 status_c_rsvd -#100 1 r 0 uf_flag -#101 1 r 0 af_flag -#102 1 r 0 pf_flag -#103 1 r 0 irqf_flag -# ----------------------------------------------------------------- -# Status Register D -#104 7 r 0 status_d_rsvd -#111 1 r 0 valid_cmos_ram -# ----------------------------------------------------------------- -# Diagnostic Status Register -#112 8 r 0 diag_rsvd1 - # ----------------------------------------------------------------- 0 120 r 0 reserved_memory -#120 264 r 0 unused # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#390 5 r 0 unused? # ----------------------------------------------------------------- # coreboot config options: console @@ -42,10 +21,8 @@ entries 411 1 e 1 nmi # coreboot config options: cpu -#424 8 r 0 unused # coreboot config options: northbridge -#432 554 r 0 unused # coreboot config options: check sums 984 16 h 0 check_sum diff --git a/src/mainboard/asus/p5ql-em/cmos.layout b/src/mainboard/asus/p5ql-em/cmos.layout index e98886258b..b306341dc5 100644 --- a/src/mainboard/asus/p5ql-em/cmos.layout +++ b/src/mainboard/asus/p5ql-em/cmos.layout @@ -5,29 +5,24 @@ entries # ----------------------------------------------------------------- 0 120 r 0 reserved_memory -#120 264 r 0 unused # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#390 5 r 0 unused # ----------------------------------------------------------------- # coreboot config options: console 395 4 e 6 debug_level # coreboot config options: southbridge -#408 1 e 0 unused 409 2 e 7 power_on_after_fail 411 1 e 1 nmi # coreboot config options: cpu -#424 8 r 0 unused # coreboot config options: northbridge 432 4 e 11 gfx_uma_size -#436 548 r 0 unused # coreboot config options: check sums 984 16 h 0 check_sum diff --git a/src/mainboard/asus/p5qpl-am/cmos.layout b/src/mainboard/asus/p5qpl-am/cmos.layout index b1f6e77558..cbf83229c9 100644 --- a/src/mainboard/asus/p5qpl-am/cmos.layout +++ b/src/mainboard/asus/p5qpl-am/cmos.layout @@ -3,51 +3,26 @@ # ----------------------------------------------------------------- entries -# ----------------------------------------------------------------- -# Status Register A -# ----------------------------------------------------------------- -# Status Register B -# ----------------------------------------------------------------- -# Status Register C -#96 4 r 0 status_c_rsvd -#100 1 r 0 uf_flag -#101 1 r 0 af_flag -#102 1 r 0 pf_flag -#103 1 r 0 irqf_flag -# ----------------------------------------------------------------- -# Status Register D -#104 7 r 0 status_d_rsvd -#111 1 r 0 valid_cmos_ram -# ----------------------------------------------------------------- -# Diagnostic Status Register -#112 8 r 0 diag_rsvd1 - # ----------------------------------------------------------------- 0 120 r 0 reserved_memory -#120 264 r 0 unused # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#390 5 r 0 unused? # ----------------------------------------------------------------- # coreboot config options: console 395 4 e 6 debug_level -#399 1 r 0 unused # coreboot config options: southbridge 408 1 e 1 nmi 409 2 e 7 power_on_after_fail # coreboot config options: cpu -#424 8 r 0 unused # coreboot config options: northbridge 432 4 e 11 gfx_uma_size -#435 549 r 0 unused - # coreboot config options: check sums 984 16 h 0 check_sum diff --git a/src/mainboard/asus/p8h61-m_lx/cmos.layout b/src/mainboard/asus/p8h61-m_lx/cmos.layout index 2aef2ac876..7fcbcfbfd4 100644 --- a/src/mainboard/asus/p8h61-m_lx/cmos.layout +++ b/src/mainboard/asus/p8h61-m_lx/cmos.layout @@ -3,28 +3,8 @@ # ----------------------------------------------------------------- entries -# ----------------------------------------------------------------- -# Status Register A -# ----------------------------------------------------------------- -# Status Register B -# ----------------------------------------------------------------- -# Status Register C -#96 4 r 0 status_c_rsvd -#100 1 r 0 uf_flag -#101 1 r 0 af_flag -#102 1 r 0 pf_flag -#103 1 r 0 irqf_flag -# ----------------------------------------------------------------- -# Status Register D -#104 7 r 0 status_d_rsvd -#111 1 r 0 valid_cmos_ram -# ----------------------------------------------------------------- -# Diagnostic Status Register -#112 8 r 0 diag_rsvd1 - # ----------------------------------------------------------------- 0 120 r 0 reserved_memory -#120 264 r 0 unused # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) @@ -33,9 +13,7 @@ entries # ----------------------------------------------------------------- # coreboot config options: console -#392 3 r 0 unused 395 4 e 4 debug_level -#399 1 r 0 unused #400 8 r 0 reserved for century byte diff --git a/src/mainboard/asus/p8h61-m_pro/cmos.layout b/src/mainboard/asus/p8h61-m_pro/cmos.layout index 1860a78326..0913b6d66d 100644 --- a/src/mainboard/asus/p8h61-m_pro/cmos.layout +++ b/src/mainboard/asus/p8h61-m_pro/cmos.layout @@ -3,55 +3,28 @@ # ----------------------------------------------------------------- entries -# ----------------------------------------------------------------- -# Status Register A -# ----------------------------------------------------------------- -# Status Register B -# ----------------------------------------------------------------- -# Status Register C -#96 4 r 0 status_c_rsvd -#100 1 r 0 uf_flag -#101 1 r 0 af_flag -#102 1 r 0 pf_flag -#103 1 r 0 irqf_flag -# ----------------------------------------------------------------- -# Status Register D -#104 7 r 0 status_d_rsvd -#111 1 r 0 valid_cmos_ram -# ----------------------------------------------------------------- -# Diagnostic Status Register -#112 8 r 0 diag_rsvd1 - # ----------------------------------------------------------------- 0 120 r 0 reserved_memory -#120 264 r 0 unused # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#390 2 r 0 unused? # ----------------------------------------------------------------- # coreboot config options: console -#392 3 r 0 unused 395 4 e 6 debug_level -#399 1 r 0 unused # coreboot config options: southbridge 408 1 e 1 nmi 409 2 e 7 power_on_after_fail -#411 10 r 0 unused 421 1 e 9 sata_mode -#422 2 r 0 unused # coreboot config options: cpu -#425 7 r 0 unused # coreboot config options: northbridge 432 3 e 11 gfx_uma_size -#435 549 r 0 unused # coreboot config options: check sums 984 16 h 0 check_sum diff --git a/src/mainboard/asus/p8z77-m_pro/cmos.layout b/src/mainboard/asus/p8z77-m_pro/cmos.layout index 1b82ffde13..a912c29496 100644 --- a/src/mainboard/asus/p8z77-m_pro/cmos.layout +++ b/src/mainboard/asus/p8z77-m_pro/cmos.layout @@ -3,28 +3,8 @@ # ----------------------------------------------------------------- entries -# ----------------------------------------------------------------- -# Status Register A -# ----------------------------------------------------------------- -# Status Register B -# ----------------------------------------------------------------- -# Status Register C -#96 4 r 0 status_c_rsvd -#100 1 r 0 uf_flag -#101 1 r 0 af_flag -#102 1 r 0 pf_flag -#103 1 r 0 irqf_flag -# ----------------------------------------------------------------- -# Status Register D -#104 7 r 0 status_d_rsvd -#111 1 r 0 valid_cmos_ram -# ----------------------------------------------------------------- -# Diagnostic Status Register -#112 8 r 0 diag_rsvd1 - # ----------------------------------------------------------------- 0 120 r 0 reserved_memory -#120 264 r 0 unused # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) @@ -33,9 +13,7 @@ entries # ----------------------------------------------------------------- # coreboot config options: console -#392 3 r 0 unused 395 4 e 4 debug_level -#399 1 r 0 unused #400 8 r 0 reserved for century byte # ----------------------------------------------------------------- -- cgit v1.2.3