From c5d6af43fb544423fa103f523ac85356b3ff3725 Mon Sep 17 00:00:00 2001 From: Keith Hui Date: Mon, 20 Mar 2023 02:03:47 -0400 Subject: nb/intel/snb: Abolish mainboard_should_reset_usb() Of the 13 mainboards that implement mainboard_should_reset_usb() hook, all but one do the same: Stop MRC from resetting USB when resuming from S3 suspend. This hook turns out is only here to facilitate a USB reset workaround on samsung/stumpy for an old ChromeOS kernel which is no longer needed. Drop the workaround, the hook, and headers no longer used. roda/rv11/early_init.c is left with no useful code after this patch, so drop it entirely from both bootblock and romstage. Change-Id: Ib3a5a00c0a6b1528e39435784919223d16b3914e Signed-off-by: Keith Hui Reviewed-on: https://review.coreboot.org/c/coreboot/+/72496 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/mainboard/asus/p8x7x-series/variants/p8z77-m/early_init.c | 5 ----- src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c | 5 ----- 2 files changed, 10 deletions(-) (limited to 'src/mainboard/asus/p8x7x-series') diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-m/early_init.c b/src/mainboard/asus/p8x7x-series/variants/p8z77-m/early_init.c index dfcdd231ef..9b4fa1da49 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-m/early_init.c +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-m/early_init.c @@ -50,11 +50,6 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only) read_spd(&spd[3], 0x53, id_only); } -int mainboard_should_reset_usb(int s3resume) -{ - return !s3resume; -} - void mainboard_fill_pei_data(struct pei_data *pei) { uint8_t spdaddr[] = {0xa0, 0xa2, 0xa4, 0xa6}; /* SMBus mul 2 */ diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c b/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c index 374ff9dd71..a93f5e942a 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c @@ -56,11 +56,6 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only) read_spd(&spd[3], 0x53, id_only); } -int mainboard_should_reset_usb(int s3resume) -{ - return !s3resume; -} - void mainboard_fill_pei_data(struct pei_data *pei_data) { /* -- cgit v1.2.3