From 714709fde638acdaa31b8e49b1f12c43f3f6b3d6 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Mon, 7 Aug 2017 20:10:28 +0300 Subject: AMD fam10 ACPI: Use common fixed sleepstates.asl MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit SSFG was meant to be used as a mask to enable sleepstates _S1 thru _S4. However as a logical instead of bitwise 'and' operation was used, all the states were enabled if only one was marked available. Note that all boards incorrectly had SSFG == 0x0D that previously enabled ACPI S3 sleep state even when it was not available. Change-Id: Ia948becff079383cbf861468da9e8a3ebbf213cb Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/21093 Tested-by: build bot (Jenkins) Reviewed-by: Marc Jones --- src/mainboard/asus/kcma-d8/dsdt.asl | 7 ------- 1 file changed, 7 deletions(-) (limited to 'src/mainboard/asus/kcma-d8') diff --git a/src/mainboard/asus/kcma-d8/dsdt.asl b/src/mainboard/asus/kcma-d8/dsdt.asl index dab489b393..5242dfaaa6 100644 --- a/src/mainboard/asus/kcma-d8/dsdt.asl +++ b/src/mainboard/asus/kcma-d8/dsdt.asl @@ -50,13 +50,6 @@ DefinitionBlock ( /* HPET enable */ Name (HPTE, 0x1) - /* Define power states */ - Name (\_S0, Package () { 0x00, 0x00, 0x00, 0x00 }) /* Normal operation */ - Name (\_S1, Package () { 0x01, 0x01, 0x00, 0x00 }) /* Standby */ - Name (\_S3, Package () { 0x03, 0x03, 0x00, 0x00 }) /* Suspend to RAM */ - Name (\_S4, Package () { 0x04, 0x04, 0x00, 0x00 }) /* Suspend to disk */ - Name (\_S5, Package () { 0x05, 0x05, 0x00, 0x00 }) /* Hard power off */ - /* The _PIC method is called by the OS to choose between interrupt * routing via the i8259 interrupt controller or the APIC. * -- cgit v1.2.3